Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jira): Improve logging in installation pipeline to debug cust issue #83879

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Jan 22, 2025

For this Zendesk ticket: https://sentry.zendesk.com/agent/tickets/135630

I have a google logs query working to see if I can get the error they ran into during installation but we're missing some key fields in some important logging which makes life sad aka the query's taking like >hour

Update: The query came back and showed "No Data" for all the logger.infos in pipeline.py except dialog_response. Unfortunately we don't capture the data/info within dialog_response 😭

@Christinarlong Christinarlong marked this pull request as ready for review January 22, 2025 23:00
@Christinarlong Christinarlong requested review from a team as code owners January 22, 2025 23:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 22, 2025
src/sentry/integrations/pipeline.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #83879      +/-   ##
==========================================
+ Coverage   85.64%   87.70%   +2.05%     
==========================================
  Files        9498     9509      +11     
  Lines      541790   545869    +4079     
  Branches    21242    21242              
==========================================
+ Hits       464040   478763   +14723     
+ Misses      77385    66741   -10644     
  Partials      365      365              

@Christinarlong Christinarlong enabled auto-merge (squash) January 23, 2025 00:11
@Christinarlong Christinarlong merged commit 30c6c58 into master Jan 23, 2025
50 checks passed
@Christinarlong Christinarlong deleted the crl/add-logging-for-jira-issue branch January 23, 2025 00:21
@cathteng
Copy link
Member

err you missed all the other places where you didn't check if self.organization is None

@Christinarlong Christinarlong added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jan 23, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: a3a80ab

getsentry-bot added a commit that referenced this pull request Jan 23, 2025
…g cust issue (#83879)"

This reverts commit 30c6c58.

Co-authored-by: Christinarlong <[email protected]>
JoshFerge pushed a commit that referenced this pull request Jan 23, 2025
…g cust issue (#83879)"

This reverts commit 30c6c58.

Co-authored-by: Christinarlong <[email protected]>
andrewshie-sentry pushed a commit that referenced this pull request Jan 29, 2025
…g cust issue (#83879)"

This reverts commit 30c6c58.

Co-authored-by: Christinarlong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants