-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jira): Improve logging in installation pipeline to debug cust issue #83879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Jan 22, 2025
cathteng
approved these changes
Jan 22, 2025
Co-authored-by: Cathy Teng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83879 +/- ##
==========================================
+ Coverage 85.64% 87.70% +2.05%
==========================================
Files 9498 9509 +11
Lines 541790 545869 +4079
Branches 21242 21242
==========================================
+ Hits 464040 478763 +14723
+ Misses 77385 66741 -10644
Partials 365 365 |
err you missed all the other places where you didn't check if self.organization is None |
Christinarlong
added
the
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Jan 23, 2025
PR reverted: a3a80ab |
getsentry-bot
added a commit
that referenced
this pull request
Jan 23, 2025
…g cust issue (#83879)" This reverts commit 30c6c58. Co-authored-by: Christinarlong <[email protected]>
JoshFerge
pushed a commit
that referenced
this pull request
Jan 23, 2025
…g cust issue (#83879)" This reverts commit 30c6c58. Co-authored-by: Christinarlong <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
…g cust issue (#83879)" This reverts commit 30c6c58. Co-authored-by: Christinarlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Trigger: Revert
Add to a merged PR to revert it (skips CI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this Zendesk ticket: https://sentry.zendesk.com/agent/tickets/135630
Update: The query came back and showed "No Data" for all the logger.infos in
pipeline.py
exceptdialog_response
. Unfortunately we don't capture the data/info within dialog_response 😭