ref(sign-up): Add external providers options #83821
Closed
+183
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
priscilawebdev
commented
Jan 22, 2025
•
priscilawebdev
commented
- Contributes to Onboarding: confusing message for the users that don't have Sentry account but are invited to the team #79399
| Before | After |
|---|---|
 |
 |
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
Jan 22, 2025
|
|
||
| const orgSlug = ConfigStore.getState().customerDomain?.subdomain; | ||
| // TODO(Telemetry): Remove the condition below after checking that everything is working fine | ||
| const displayExternalProviders = orgSlug === 'pri-sentry'; |
There was a problem hiding this comment.
Since the invited user might not be logged in yet, we cannot use our feature flag tool in this case. To test it before making it public, I’m adding checking against an org that I use specifically for testing purposes
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83821 +/- ##
========================================
Coverage 87.62% 87.63%
========================================
Files 9506 9503 -3
Lines 541906 541769 -137
Branches 21215 21215
========================================
- Hits 474872 474766 -106
+ Misses 66668 66637 -31
Partials 366 366 |
…com:getsentry/sentry into priscila/ref/sign-up/add-external-providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.