✨ feat(threads): Update threading behavior for Uptime Alerts

.github/workflows/scripts/deploy.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 /**
  * GHA Workflow helpers for deploys
  *

.github/workflows/scripts/getsentry-dispatch.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 /**
  * List of workflows to dispatch to `getsentry`
  *

api-docs/index.ts

@@ -1,27 +1,26 @@
-/* global process */
-/* eslint-env node */
-/* eslint import/no-unresolved:0 */
 import yaml from 'js-yaml';
 import JsonRefs from 'json-refs';
 import fs from 'node:fs';
 import path from 'node:path';
 
 function dictToString(dict) {
-  const res = [];
+  const res: string[] = [];
   for (const [k, v] of Object.entries(dict)) {
     res.push(`${k}: ${v}`);
   }
   return res.join('\n');
 }
 
 function bundle(originalFile) {
+  // @ts-expect-error: Types do not match the version of js-yaml installed
   const root = yaml.safeLoad(fs.readFileSync(originalFile, 'utf8'));
   const options = {
     filter: ['relative', 'remote', 'local'],
     resolveCirculars: true,
     location: originalFile,
     loaderOptions: {
       processContent: function (res, callback) {
+        // @ts-expect-error: Types do not match the version of js-yaml installed
         callback(undefined, yaml.safeLoad(res.text));
       },
     },

api-docs/openapi-diff.ts

@@ -1,6 +1,3 @@
-/* eslint-env node */
-/* eslint import/no-unresolved:0 */
-
 import yaml from 'js-yaml';
 import jsonDiff from 'json-diff';
 import fs from 'node:fs';
@@ -26,6 +23,7 @@ async function main() {
   );
 
   const readFile = fs.readFileSync('tests/apidocs/openapi-derefed.json', 'utf8');
+  // @ts-expect-error: Types do not match the version of js-yaml installed
   const target = yaml.safeLoad(readFile);
 
   // eslint-disable-next-line no-console

api-docs/watch.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-/* eslint import/no-unresolved:0, no-console:0 */
 import {spawn} from 'node:child_process';
 import {join} from 'node:path';
 import {stderr, stdout} from 'node:process';

babel.config.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import type {TransformOptions} from '@babel/core';
 
 const config: TransformOptions = {

build-utils/last-built-plugin.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import fs from 'node:fs';
 import path from 'node:path';
 import type webpack from 'webpack';

build-utils/sentry-instrumentation.ts

@@ -1,4 +1,3 @@
-/* eslint-env node */
 import type {Span} from '@sentry/core';
 import type * as Sentry from '@sentry/node';
 import crypto from 'node:crypto';

config/webpack.chartcuterie.config.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import childProcess from 'node:child_process';
 import path from 'node:path';
 import webpack from 'webpack';

devenv/sync.py

@@ -253,8 +253,10 @@ def main(context: dict[str, str]) -> int:
 
     fs.ensure_symlink("../../config/hooks/post-merge", f"{reporoot}/.git/hooks/post-merge")
 
-    if not os.path.exists(f"{constants.home}/.sentry/config.yml") or not os.path.exists(
-        f"{constants.home}/.sentry/sentry.conf.py"
+    sentry_conf = os.environ.get("SENTRY_CONF", f"{constants.home}/.sentry")
+
+    if not os.path.exists(f"{sentry_conf}/config.yml") or not os.path.exists(
+        f"{sentry_conf}/sentry.conf.py"
     ):
         proc.run((f"{venv_dir}/bin/sentry", "init", "--dev"))
 

eslint.config.mjs

@@ -25,6 +25,7 @@ import simpleImportSort from 'eslint-plugin-simple-import-sort';
 import testingLibrary from 'eslint-plugin-testing-library';
 // @ts-expect-error TS (7016): Could not find a declaration file
 import typescriptSortKeys from 'eslint-plugin-typescript-sort-keys';
+import unicorn from 'eslint-plugin-unicorn';
 import globals from 'globals';
 import invariant from 'invariant';
 // biome-ignore lint/correctness/noNodejsModules: Need to get the list of things!
@@ -236,6 +237,7 @@ export default typescript.config([
       'consistent-return': 'error',
       'default-case': 'error',
       'dot-notation': 'error',
+      eqeqeq: 'error',
       'guard-for-in': 'off', // TODO(ryan953): Fix violations and enable this rule
       'multiline-comment-style': ['error', 'separate-lines'],
       'no-alert': 'error',
@@ -268,6 +270,7 @@ export default typescript.config([
       'no-sequences': 'error',
       'no-throw-literal': 'error',
       'object-shorthand': ['error', 'properties'],
+      radix: 'error',
       'require-await': 'error', // Enabled in favor of @typescript-eslint/require-await, which requires type info
       'spaced-comment': [
         'error',
@@ -277,10 +280,9 @@ export default typescript.config([
           block: {exceptions: ['*'], balanced: true},
         },
       ],
+      strict: 'error',
       'vars-on-top': 'off',
       'wrap-iife': ['error', 'any'],
-      radix: 'error',
-      strict: 'error',
       yoda: 'error',
 
       // https://github.com/eslint/eslint/blob/main/packages/js/src/configs/eslint-recommended.js
@@ -306,6 +308,7 @@ export default typescript.config([
       'import/no-anonymous-default-export': 'error',
       'import/no-duplicates': 'error',
       'import/no-named-default': 'error',
+      'import/no-nodejs-modules': 'error',
       'import/no-webpack-loader-syntax': 'error',
 
       // https://github.com/import-js/eslint-plugin-import/blob/main/config/recommended.js
@@ -369,6 +372,7 @@ export default typescript.config([
         {selector: 'typeLike', format: ['PascalCase'], leadingUnderscore: 'allow'},
         {selector: 'enumMember', format: ['UPPER_CASE']},
       ],
+
       '@typescript-eslint/no-restricted-types': [
         'error',
         {
@@ -392,6 +396,7 @@ export default typescript.config([
       ],
       '@typescript-eslint/no-shadow': 'error',
       '@typescript-eslint/no-use-before-define': 'off', // Enabling this will cause a lot of thrash to the git history
+      '@typescript-eslint/no-useless-empty-export': 'error',
     },
   },
   // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/base.ts
@@ -406,8 +411,8 @@ export default typescript.config([
     // https://typescript-eslint.io/rules/
     plugins: {'@typescript-eslint': typescript.plugin},
     rules: {
-      'no-var': 'off', // TODO(ryan953): Fix violations and delete this line
       'prefer-spread': 'off', // TODO(ryan953): Fix violations and delete this line
+      '@typescript-eslint/prefer-enum-initializers': 'error',
 
       // Recommended overrides
       '@typescript-eslint/ban-ts-comment': 'off', // TODO(ryan953): Fix violations and delete this line
@@ -427,7 +432,6 @@ export default typescript.config([
       '@typescript-eslint/no-extraneous-class': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-invalid-void-type': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-non-null-assertion': 'off', // TODO(ryan953): Fix violations and delete this line
-      '@typescript-eslint/prefer-literal-enum-member': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/unified-signatures': 'off', // TODO(ryan953): Fix violations and delete this line
 
       // Stylistic overrides
@@ -439,7 +443,6 @@ export default typescript.config([
       '@typescript-eslint/no-empty-function': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/no-inferrable-types': 'off', // TODO(ryan953): Fix violations and delete this line
       '@typescript-eslint/prefer-for-of': 'off', // TODO(ryan953): Fix violations and delete this line
-      '@typescript-eslint/prefer-function-type': 'off', // TODO(ryan953): Fix violations and delete this line
 
       // Customization
       '@typescript-eslint/no-unused-vars': [
@@ -495,13 +498,13 @@ export default typescript.config([
         {
           groups: [
             // Side effect imports.
-            ['^\\u0000'],
+            [String.raw`^\u0000`],
 
             // Node.js builtins.
             [`^(${builtinModules.join('|')})(/|$)`],
 
             // Packages. `react` related packages come first.
-            ['^react', '^@?\\w'],
+            ['^react', String.raw`^@?\w`],
 
             // Test should be separate from the app
             ['^(sentry-test|getsentry-test)(/.*|$)'],
@@ -517,13 +520,13 @@ export default typescript.config([
             ['^(admin|getsentry)(/.*|$)'],
 
             // Style imports.
-            ['^.+\\.less$'],
+            [String.raw`^.+\.less$`],
 
             // Parent imports. Put `..` last.
-            ['^\\.\\.(?!/?$)', '^\\.\\./?$'],
+            [String.raw`^\.\.(?!/?$)`, String.raw`^\.\./?$`],
 
             // Other relative imports. Put same-folder imports and `.` last.
-            ['^\\./(?=.*/)(?!/?$)', '^\\.(?!/?$)', '^\\./?$'],
+            [String.raw`^\./(?=.*/)(?!/?$)`, String.raw`^\.(?!/?$)`, String.raw`^\./?$`],
           ],
         },
       ],
@@ -552,32 +555,35 @@ export default typescript.config([
       '@emotion/syntax-preference': ['error', 'string'],
     },
   },
+  {
+    name: 'plugin/unicorn',
+    plugins: {unicorn},
+    rules: {
+      // The recommended rules are very opinionated. We don't need to enable them.
+
+      'unicorn/no-instanceof-array': 'error',
+      'unicorn/prefer-array-flat-map': 'error',
+      'unicorn/prefer-node-protocol': 'error',
+    },
+  },
   {
     name: 'plugin/jest',
     files: ['**/*.spec.{ts,js,tsx,jsx}', 'tests/js/**/*.{ts,js,tsx,jsx}'],
     // https://github.com/jest-community/eslint-plugin-jest/tree/main/docs/rules
     plugins: jest.configs['flat/recommended'].plugins,
     rules: {
+      'jest/max-nested-describe': 'error',
+      'jest/no-duplicate-hooks': 'error',
+      'jest/no-large-snapshots': ['error', {maxSize: 2000}], // We don't recommend snapshots, but if there are any keep it small
+
       // https://github.com/jest-community/eslint-plugin-jest/blob/main/src/index.ts
       ...jest.configs['flat/recommended'].rules,
       ...jest.configs['flat/style'].rules,
 
-      // `recommended` set this to warn, we've upgraded to error
-      'jest/no-disabled-tests': 'error',
-
-      // `recommended` set this to warn, we've downgraded to off
-      // Disabled as we have many tests which render as simple validations
-      'jest/expect-expect': 'off',
-
-      // Disabled as we have some comment out tests that cannot be
-      // uncommented due to typescript errors.
+      'jest/expect-expect': 'off', // Disabled as we have many tests which render as simple validations
       'jest/no-commented-out-tests': 'off', // TODO(ryan953): Fix violations then delete this line
-
-      // Disabled as we do sometimes have conditional expects
       'jest/no-conditional-expect': 'off', // TODO(ryan953): Fix violations then delete this line
-
-      // We don't recommend snapshots, but if there are any keep it small
-      'jest/no-large-snapshots': ['error', {maxSize: 2000}],
+      'jest/no-disabled-tests': 'error', // `recommended` set this to warn, we've upgraded to error
     },
   },
   {
@@ -604,13 +610,17 @@ export default typescript.config([
   },
   {
     name: 'files/*.config.*',
-    files: ['*.config.*'],
+    files: ['**/*.config.*'],
     languageOptions: {
       globals: {
         ...globals.commonjs,
         ...globals.node,
       },
     },
+
+    rules: {
+      'import/no-nodejs-modules': 'off',
+    },
   },
   {
     name: 'files/scripts',
@@ -624,6 +634,8 @@ export default typescript.config([
     },
     rules: {
       'no-console': 'off',
+
+      'import/no-nodejs-modules': 'off',
     },
   },
   {
@@ -632,15 +644,19 @@ export default typescript.config([
       'tests/js/jest-pegjs-transform.js',
       'tests/js/sentry-test/echartsMock.js',
       'tests/js/sentry-test/importStyleMock.js',
+      'tests/js/sentry-test/loadFixtures.ts',
       'tests/js/sentry-test/svgMock.js',
+      'tests/js/setup.ts',
     ],
     languageOptions: {
       sourceType: 'commonjs',
       globals: {
         ...globals.commonjs,
       },
     },
-    rules: {},
+    rules: {
+      'import/no-nodejs-modules': 'off',
+    },
   },
   {
     name: 'files/devtoolbar',

jest.config.ts

@@ -1,4 +1,3 @@
-/* eslint-env node */
 import type {Config} from '@jest/types';
 import path from 'node:path';
 import process from 'node:process';

migrations_lockfile.txt

@@ -21,6 +21,6 @@ social_auth: 0002_default_auto_field
 
 tempest: 0001_create_tempest_credentials_model
 
-uptime: 0021_drop_region_table_col
+uptime: 0022_add_trace_sampling_to_uptime_monitors
 
 workflow_engine: 0023_create_action_trigger_action_table

package.json

@@ -60,7 +60,7 @@
     "@sentry/node": "8.48.0",
     "@sentry/react": "8.48.0",
     "@sentry/release-parser": "^1.3.1",
-    "@sentry/status-page-list": "^0.3.0",
+    "@sentry/status-page-list": "^0.6.0",
     "@sentry/types": "8.48.0",
     "@sentry/utils": "8.48.0",
     "@sentry/webpack-plugin": "^2.22.4",
@@ -146,7 +146,6 @@
     "qrcode.react": "^3.1.0",
     "query-string": "7.0.1",
     "react": "18.2.0",
-    "react-textarea-autosize": "8.5.7",
     "react-date-range": "^1.4.0",
     "react-dom": "18.2.0",
     "react-grid-layout": "^1.3.4",
@@ -156,6 +155,7 @@
     "react-router-dom": "^6.26.2",
     "react-select": "4.3.1",
     "react-sparklines": "1.7.0",
+    "react-textarea-autosize": "8.5.7",
     "react-virtualized": "^9.22.5",
     "reflux": "0.4.1",
     "screenfull": "^6.0.2",
@@ -205,6 +205,7 @@
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-testing-library": "^7.1.1",
     "eslint-plugin-typescript-sort-keys": "^3.3.0",
+    "eslint-plugin-unicorn": "^56.0.1",
     "globals": "^15.14.0",
     "html-webpack-plugin": "^5.6.0",
     "jest": "29.7.0",
@@ -213,7 +214,7 @@
     "jest-fail-on-console": "3.3.0",
     "jest-junit": "16.0.0",
     "postcss-styled-syntax": "0.7.0",
-    "react-refresh": "0.14.0",
+    "react-refresh": "0.16.0",
     "stylelint": "16.10.0",
     "stylelint-config-recommended": "^14.0.1",
     "terser": "5.31.6",

pyproject.toml

@@ -152,7 +152,6 @@ module = [
     "sentry.api.permissions",
     "sentry.api.serializers.models.auth_provider",
     "sentry.api.serializers.models.event",
-    "sentry.api.serializers.models.group_stream",
     "sentry.api.serializers.models.role",
     "sentry.auth.helper",
     "sentry.auth.provider",
@@ -208,9 +207,6 @@ module = [
     "sentry.integrations.slack.integration",
     "sentry.integrations.slack.message_builder.notifications.issues",
     "sentry.integrations.slack.notifications",
-    "sentry.integrations.slack.unfurl.discover",
-    "sentry.integrations.slack.utils.channel",
-    "sentry.integrations.slack.utils.users",
     "sentry.integrations.slack.webhooks.command",
     "sentry.integrations.slack.webhooks.event",
     "sentry.integrations.utils.commit_context",
@@ -302,7 +298,6 @@ disable_error_code = [
     "override",
     "return-value",
     "typeddict-item",
-    "typeddict-unknown-key",
     "union-attr",
     "unreachable",
     "var-annotated",