ref: Convert AddCodeOwnersModal to FC #83690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83690 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 9488 9488
Lines 539335 539295 -40
Branches 21230 21226 -4
=======================================
- Hits 472356 472322 -34
+ Misses 66631 66625 -6
Partials 348 348 |
static/app/views/settings/project/projectOwnership/addCodeOwnerModal.tsx
Outdated
Show resolved
Hide resolved
ryan953
force-pushed
the
ryan953/ref-AddCodeOwnersModal-FC
branch
from
58e949a to
c40792b
Compare
malwilley
reviewed
Jan 21, 2025
| const {codeownersFile, codeMappingId, codeMappings} = this.state; | ||
| const { | ||
| data: codeownersFile, | ||
| isPending: isCodeownersFilePending, |
There was a problem hiding this comment.
Note that this will be true whenever this query is disabled. If that's not what you want, you should use isLoading instead
| const addFile = useCallback(() => { | ||
| if (codeownersFile) { | ||
| mutation.mutate([{codeMappingId, raw: codeownersFile.raw}], { | ||
| onSuccess: d => { |
There was a problem hiding this comment.
Usually we put these onSuccess and onError handlers in the original useMutation, but this will have the same effect
michellewzhang
approved these changes
Jan 22, 2025
Bundle ReportChanges will increase total bundle size by 1.86MB (5.9%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
malwilley
approved these changes
Jan 22, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.