✨ feat(notifications): open_period_start_for_group util for threads
#83689
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
commented
Jan 17, 2025
| from sentry.models.group import Group | ||
|
|
||
|
|
||
| def open_period_start_for_group(group: Group) -> datetime | None: |
There was a problem hiding this comment.
open to moving this somewhere else, i think we should have a single place where we store these types of utils to work with Open Periods for notifications/issue platform.
as we figure out what types of methods exist, we can start bringing them together, open to leaving this as a todo
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a function that returns the latest "open period" for a particular group. It will be used as a
keyin future threads refactor PR to create 1 thread per open group.One example use case is to return the latest open period for an Uptime Issue.
spec: notion.so/sentry/Slack-Threads-Refactor-1618b10e4b5d807db67ae6d4d85247b9
contributes to: getsentry.atlassian.net/browse/ACI-89