feat(forms): add segmented radio field #83557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Jan 15, 2025
|
|
||
| return ( | ||
| <Tooltip | ||
| key={index} |
There was a problem hiding this comment.
key could maybe be id but maybe we don't know that will be unique
scttcper
approved these changes
Jan 15, 2025
saponifi3d
approved these changes
Jan 15, 2025
| import {space} from 'sentry/styles/space'; | ||
|
|
||
| export interface SegmentedRadioFieldProps extends Omit<InputFieldProps, 'type'> { | ||
| choices?: RadioGroupProps<any>['choices']; |
There was a problem hiding this comment.
🤔 should this any propagate the generic type down instead?
There was a problem hiding this comment.
Ah great catch, missed this in the copy + paste. Fixed in 2889f50!
|
link to one of the recent vercel stories https://sentry-i5qt28rm9.sentry.dev/stories/?name=app%2Fcomponents%2Fforms%2Ffields%2Findex.stories.tsx&query= |
Bundle ReportChanges will increase total bundle size by 3.78kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
natemoo-re
force-pushed
the
aci/m61-segmented-radio
branch
from
9541fb8 to
2889f50
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Introduces a new segmented radio field (mostly copied from the existing radio field, with some styling changes) - fixes an accessibility issue with the existing radio field, which did not pass `name` down to the `input`. Without this change, keyboard navigation for multiple radio fields on the same page was broken.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ACI M6.1.
namedown to theinput. Without this change, keyboard navigation for multiple radio fields on the same page was broken.