Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): Add meta to the stats response #83538

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(rpc): Add meta to the stats response #83538

wants to merge 4 commits into from
+78 −38

Conversation

wmak
Copy link
Member

@wmak wmak commented Jan 15, 2025 •
edited
Loading

@wmak
feat(rpc): Add meta to the stats response
d63825c 
- Missed adding stats to the stats responses
- TODO: need to update top_events after
  #83446 merges
- Fixed a bug where count_unique was the wrong type
@wmak wmak requested a review from a team as a code owner January 15, 2025 21:28
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #83538      +/-   ##
==========================================
+ Coverage   84.91%   87.65%   +2.74%     
==========================================
  Files        9517     9521       +4     
  Lines      542051   543396    +1345     
  Branches    21228    21228              
==========================================
+ Hits       460294   476332   +16038     
+ Misses      81391    66698   -14693     
  Partials      366      366

@gggritso gggritso mentioned this pull request Jan 22, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wmak