Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): register flag for wip eap #81742

Closed
wants to merge 1 commit into from
Closed

feat(insights): register flag for wip eap #81742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,8 @@ def register_temporary_features(manager: FeatureManager):
manager.add("organizations:insights-query-date-range-limit", OrganizationFeature, FeatureHandlerStrategy.INTERNAL, api_expose=True)
# Make Insights modules use EAP instead of metrics
manager.add("organizations:insights-use-eap", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Make Insights modules use EAP instead of metrics, but for area's that are still WIP
manager.add("organizations:insights-use-eap-wip", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Comment on lines +453 to +454
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing "organizations:insights-use-eap" flag name really painted you into a corner for this second flag, eh? Honestly not a bad idea to replace that flag with "organizations:insights-llm-module-use-eap" but not important.

Anyway, I think "organization:insights-all-modules-use-eap" is a little better than the "-wip" prefix, since a feature flag is kind of a WIP by nature, but again, not that important.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this a bit more, why not use the existing feature flag? Any functionality that doesn't work on EAP won't work until it's implemented, which makes sense, right?

# Enable access to insights metrics alerts
manager.add("organizations:insights-alerts", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable Related Issues table in Insights modules
Expand Down
Loading