Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling) hint to opening aggregate flamegraph #80698

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 13, 2024

Add a banner that links to docs and hints to users that they should open the flamegraph tab in the off change that they are only sending us profiling data and no tracing data.

@shellmayr this would also help with the case that encountered where profiling data was empty, but it was all just on the flamegraph tab :)

@JonasBa JonasBa requested a review from Zylphrex November 13, 2024 21:50
@JonasBa JonasBa requested a review from a team as a code owner November 13, 2024 21:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/profiling/content.tsx 0.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #80698   +/-   ##
=======================================
  Coverage   78.34%   78.35%           
=======================================
  Files        7204     7196    -8     
  Lines      318617   318661   +44     
  Branches    43914    43919    +5     
=======================================
+ Hits       249616   249675   +59     
+ Misses      62648    62627   -21     
- Partials     6353     6359    +6     

@shellmayr
Copy link
Member

Ah that's a great idea - thanks for incorporating this!

@getsantry
Copy link
Contributor

getsantry bot commented Dec 6, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 6, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 29, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 29, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Jan 21, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants