-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profiling) hint to opening aggregate flamegraph #80698
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80698 +/- ##
=======================================
Coverage 78.34% 78.35%
=======================================
Files 7204 7196 -8
Lines 318617 318661 +44
Branches 43914 43919 +5
=======================================
+ Hits 249616 249675 +59
+ Misses 62648 62627 -21
- Partials 6353 6359 +6 |
Ah that's a great idea - thanks for incorporating this! |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Add a banner that links to docs and hints to users that they should open the flamegraph tab in the off change that they are only sending us profiling data and no tracing data.
@shellmayr this would also help with the case that encountered where profiling data was empty, but it was all just on the flamegraph tab :)