feat(self-hosted): Add support for rediss:// scheme
#76411
Conversation
github-actions
bot
added
the
Scope: Backend
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Would be nice to get this reviewed, but I understand if this is closed automatically. |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
mishok13
force-pushed
the
redis-tls-backend
branch
2 times, most recently
from
3d4a7aa to
a86a908
Compare
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
mishok13
force-pushed
the
redis-tls-backend
branch
from
a86a908 to
f4b34aa
Compare
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
mishok13
force-pushed
the
redis-tls-backend
branch
from
f4b34aa to
ca8adfe
Compare
Allows self-hosted users to specify Redis broker URLs with TLS enabled.
I believe this fixes #57788 and is tangentially related to #66917 and #67082. To tests this I deployed self hosted sentry in our AWS environment and pointed it at Elasticache Redis cluster with TLS in transit enabled. Before applying the patch (note that it was applied to Sentry 24.5.1) the following error would be produced:
Applying the patch resolved the issue as far as I can tell.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.