-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): Default metric alerts on project creation #76027
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 7052296.
[RuleAction.CREATE_ALERT_LATER.toString(), t("I'll create my own alerts later")], | ||
]; | ||
|
||
if (this.props.organization.features.includes('default-metric-alerts-new-projects')) { | ||
options.unshift([RuleAction.DEFAULT_ALERT.toString(), t('Alert me on issues')]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Alert me on issues" still implies issue alerts only, maybe "Alert me on issues and metrics" or something vague like "Alert me when things are bad" idk I am not a copywriter 😅
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Change the alerts step on the project creation page to just toggle alerts on or off.
The on option will create both the default metric alert and alert on every/high priority issues issue alert (the issue alert depends on the platform, as priority issue alerts are not GA'd yet)
I also changed the step name to just
Set your Alerts
and the bullet point toAlert me on Issues
, although I'm open to other names as I feel like the alerts step looks rather small in the UI compared to the other steps.Before
After
Closes ALRT-206