Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Default metric alerts on project creation #76027

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schew2381
Copy link
Contributor

@schew2381 schew2381 commented Aug 12, 2024

Change the alerts step on the project creation page to just toggle alerts on or off.

The on option will create both the default metric alert and alert on every/high priority issues issue alert (the issue alert depends on the platform, as priority issue alerts are not GA'd yet)

I also changed the step name to just Set your Alerts and the bullet point to Alert me on Issues, although I'm open to other names as I feel like the alerts step looks rather small in the UI compared to the other steps.

Before

Screenshot 2024-08-12 at 3 24 34 PM

After

Screenshot 2024-08-12 at 3 25 24 PM

Closes ALRT-206

@schew2381 schew2381 self-assigned this Aug 12, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 12, 2024
@schew2381 schew2381 requested a review from a team August 12, 2024 22:27
[RuleAction.CREATE_ALERT_LATER.toString(), t("I'll create my own alerts later")],
];

if (this.props.organization.features.includes('default-metric-alerts-new-projects')) {
options.unshift([RuleAction.DEFAULT_ALERT.toString(), t('Alert me on issues')]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Alert me on issues" still implies issue alerts only, maybe "Alert me on issues and metrics" or something vague like "Alert me when things are bad" idk I am not a copywriter 😅

@getsantry getsantry bot added the Stale label Sep 4, 2024
@getsentry getsentry deleted a comment from getsantry bot Sep 4, 2024
@schew2381 schew2381 removed the Stale label Sep 4, 2024
@getsantry getsantry bot added the Stale label Sep 26, 2024
@getsentry getsentry deleted a comment from getsantry bot Sep 26, 2024
@schew2381 schew2381 removed the Stale label Sep 26, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Oct 18, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 18, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Nov 9, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 9, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 2, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 2, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 25, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 25, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Jan 17, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants