-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
9ca0cab
commit a258563
Showing
39 changed files
with
1,120 additions
and
651 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
We think of the `grouping.in_app_frame_mix` metric as coming only from error events, but in fact we collect it durring issue platform group creation, too. This adds a `source` tag to the metric, so we can tell one from the other. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
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 - event and org admin | ||
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 - event admin | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
- no in-app frames | ||
- rule which marks all system frames as contributing | ||
|
||
|
||
+app +group | ||
app variant -> contributes, both hints | ||
system variant -> contributes, +group hint | ||
|
||
+app -group | ||
app variant -> doesn't contribute, -group hint | ||
system variant -> doesn't contribute, -group hint | ||
|
||
-app +group | ||
app variant -> doesn't contribute, -app hint | ||
system variant -> contributes, +group hint | ||
|
||
-app -group | ||
app variant -> doesn't contribute, -app hint | ||
system variant -> doesn't contribute, -group hint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
|
||
|
||
|
||
event comes in | ||
apply dynamic auto rules | ||
already has a value -> skip, copy to sdk_in_app? | ||
no value -> apply rules, set orig_in_app (always None) | ||
|
||
apply rust enhancers | ||
apply auto rules, custom rules | ||
-> already had value, source SDK, matches auto rule -> | ||
|
||
|
||
sdk value | ||
dynamic auto rules value | ||
rust value auto | ||
rust value custom | ||
|
||
final = rust custom or sdk or rust auto or dynamic | ||
|
||
dynamic_string = create_dynamic_rule_string | ||
dynamic_enhancements = Enhancements.from_config_string(dynamic_string) | ||
merged_rust_enhancements = RustEnhancements.empty() | ||
merged_rust_enhancements.extend_from(dynamic_enhancements.rust_enhancements) | ||
merged_rust_enhancements.extend_from(existing_rust_enhancements) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
|
||
https://github.com/getsentry/sentry/pull/27231 was the PR introducing min_grouping_level | ||
need to handle getting rid of isFrameUsedForGrouping, too |
Oops, something went wrong.