Skip to content

Commit

Permalink
STASH
Browse files Browse the repository at this point in the history
  • Loading branch information
lobsterkatie committed Feb 1, 2025
1 parent 9ca0cab commit a258563
Show file tree
Hide file tree
Showing 39 changed files with 1,120 additions and 651 deletions.
14 changes: 8 additions & 6 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@
"program": "${workspaceRoot}/.venv/bin/sentry",
"args": ["devserver"],
"cwd": "${workspaceRoot}",
"debugOptions": [
"WaitOnAbnormalExit",
"WaitOnNormalExit",
"RedirectOutput"
]
"debugOptions": ["WaitOnAbnormalExit", "WaitOnNormalExit", "RedirectOutput"]
},
{
"name": "sentry backend debug",
Expand Down Expand Up @@ -59,7 +55,13 @@
"type": "python",
"request": "launch",
"module": "pytest",
"args": ["--verbosity", "2", "${file}", "--reuse-db"],
"args": [
"--verbosity",
"2",
"--reuse-db",
"--last-failed",
"${file}"
],
"django": true,
"env": {
"SENTRY_MODEL_MANIFEST_FILE_PATH": "./model-manifest.json"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
We think of the `grouping.in_app_frame_mix` metric as coming only from error events, but in fact we collect it durring issue platform group creation, too. This adds a `source` tag to the metric, so we can tell one from the other.
2 changes: 2 additions & 0 deletions backfill-api-key.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
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 - event and org admin

Check warning on line 1 in backfill-api-key.txt

View workflow job for this annotation

GitHub Actions / Secret Scan

Found verified SentryToken result 🐷🔑
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 - event admin

Check warning on line 2 in backfill-api-key.txt

View workflow job for this annotation

GitHub Actions / Secret Scan

Found verified SentryToken result 🐷🔑
19 changes: 19 additions & 0 deletions double_hint_changes.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
- no in-app frames
- rule which marks all system frames as contributing


+app +group
app variant -> contributes, both hints
system variant -> contributes, +group hint

+app -group
app variant -> doesn't contribute, -group hint
system variant -> doesn't contribute, -group hint

-app +group
app variant -> doesn't contribute, -app hint
system variant -> contributes, +group hint

-app -group
app variant -> doesn't contribute, -app hint
system variant -> doesn't contribute, -group hint
25 changes: 25 additions & 0 deletions in-app-notes.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@



event comes in
apply dynamic auto rules
already has a value -> skip, copy to sdk_in_app?
no value -> apply rules, set orig_in_app (always None)

apply rust enhancers
apply auto rules, custom rules
-> already had value, source SDK, matches auto rule ->


sdk value
dynamic auto rules value
rust value auto
rust value custom

final = rust custom or sdk or rust auto or dynamic

dynamic_string = create_dynamic_rule_string
dynamic_enhancements = Enhancements.from_config_string(dynamic_string)
merged_rust_enhancements = RustEnhancements.empty()
merged_rust_enhancements.extend_from(dynamic_enhancements.rust_enhancements)
merged_rust_enhancements.extend_from(existing_rust_enhancements)
3 changes: 3 additions & 0 deletions note_re_min_grouping_level.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@

https://github.com/getsentry/sentry/pull/27231 was the PR introducing min_grouping_level
need to handle getting rid of isFrameUsedForGrouping, too
Loading

0 comments on commit a258563

Please sign in to comment.