Skip to content

Commit

Permalink
fix test and remove comment
Browse files Browse the repository at this point in the history
  • Loading branch information
mifu67 committed Jan 31, 2025
1 parent 254ec2f commit 7b67ab5
Showing 1 changed file with 1 addition and 26 deletions.
27 changes: 1 addition & 26 deletions static/app/views/alerts/rules/metric/details/metricHistory.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,31 +82,6 @@ function MetricAlertActivity({organization, incident}: MetricAlertActivityProps)
#{incident.identifier}
</Link>
</Cell>
{/* <Cell>
{incident.alertRule.comparisonDelta ? (
<Fragment>
{alertName} {curentTrigger?.alertThreshold}%
{t(
' %s in %s compared to the ',
incident.alertRule.thresholdType === AlertRuleThresholdType.ABOVE
? t('higher')
: t('lower'),
timeWindow
)}
{COMPARISON_DELTA_OPTIONS.find(
({value}) => value === incident.alertRule.comparisonDelta
)?.label ?? COMPARISON_DELTA_OPTIONS[0]?.label}
</Fragment>
) : (
<Fragment>
{alertName}{' '}
{incident.alertRule.thresholdType === AlertRuleThresholdType.ABOVE
? t('above')
: t('below')}{' '}
{curentTrigger?.alertThreshold} {t('in')} {timeWindow}
</Fragment>
)}
</Cell> */}
<Cell>
{/* If an alert rule is a % comparison based detection type */}
{incident.alertRule.detectionType !== 'dynamic' &&
Expand All @@ -133,7 +108,7 @@ function MetricAlertActivity({organization, incident}: MetricAlertActivityProps)
{incident.alertRule.thresholdType === AlertRuleThresholdType.ABOVE
? t('above')
: t('below')}{' '}
{curentTrigger?.alertThreshold || '_'} {t('within')} {timeWindow}
{curentTrigger?.alertThreshold} {t('in')} {timeWindow}
</Fragment>
)}
{/* If an alert rule is a dynamic detection type */}
Expand Down

0 comments on commit 7b67ab5

Please sign in to comment.