Skip to content

Commit

Permalink
feat(replay): Change min version in replay onboarding (#50072)
Browse files Browse the repository at this point in the history
For network details onboarding, we keep the logic of when to display the
onboarding banner the same (if sdk version < 7.50), however we want the
setup instructions to suggest a later min version as there are bugs
present in 7.50 -> 7.53 that we want users to avoid.
  • Loading branch information
billyvg authored May 31, 2023
1 parent 5288a47 commit 49247e2
Showing 1 changed file with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,12 @@ export function Setup({
showSnippet: Output;
visibleTab: TabKey;
}) {
const minVersion = '7.50.0';

const organization = useOrganization();
const {isFetching, needsUpdate} = useProjectSdkNeedsUpdate({
minVersion,
// Only show update instructions if not >= 7.50.0, but our instructions
// will show a different min version as there are known bugs in 7.50 ->
// 7.53
minVersion: '7.50.0',
organization,
projectId: [projectId],
});
Expand All @@ -135,7 +136,7 @@ export function Setup({

return (
<SetupInstructions
minVersion={minVersion}
minVersion="7.53.1"
sdkNeedsUpdate={sdkNeedsUpdate}
showSnippet={showSnippet}
url={url}
Expand Down

0 comments on commit 49247e2

Please sign in to comment.