update snapshots

getsentry · Feb 1, 2025 · 467fa8b · 467fa8b
1 parent 7530f32
commit 467fa8b
Show file tree

Hide file tree

Showing 12 changed files with 132 additions and 84 deletions.
diff --git a/...test_metadata_from_variants/newstyle@2019_05_08/contributing_system_and_app_frames.pysnap b/...test_metadata_from_variants/newstyle@2019_05_08/contributing_system_and_app_frames.pysnap
@@ -1,5 +1,5 @@
 ---
-created: '2025-01-30T21:41:17.184133+00:00'
+created: '2025-01-30T21:45:36.771348+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_grouphash_metadata.py
 ---
@@ -24,13 +24,29 @@ metrics with tags: {
 ---
 contributing variants:
   app*
-    hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+    hash: "161ce02ecc5d6685a72e8e520ab726b3"
     contributing component: exception
     component:
       app*
         exception*
           stacktrace*
-            frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+            frame* (marked in-app by stack trace rule (function:playFetch +app +group))
+              filename*
+                "dogpark.js"
+              function*
+                "playFetch"
+              context-line*
+                "raise FailedToFetchError('Charlie didn't bring the ball back!');"
+          type*
+            "FailedToFetchError"
+  system*
+    hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+    contributing component: exception
+    component:
+      system*
+        exception*
+          stacktrace*
+            frame* (marked out of app by stack trace rule (function:handleRequest -app +group))
               filename*
                 "router.js"
               function*

diff --git a/...etadata/test_metadata_from_variants/newstyle@2019_05_08/contributing_system_frames.pysnap b/...etadata/test_metadata_from_variants/newstyle@2019_05_08/contributing_system_frames.pysnap
@@ -1,13 +1,13 @@
 ---
-created: '2025-01-30T21:41:17.269522+00:00'
+created: '2025-01-30T21:45:36.965256+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_grouphash_metadata.py
 ---
 hash_basis: stacktrace
 hashing_metadata: {
   "num_stacktraces": 1,
   "stacktrace_location": "exception",
-  "stacktrace_type": "in_app"
+  "stacktrace_type": "system"
 }
 ---
 metrics with tags: {
@@ -18,19 +18,19 @@ metrics with tags: {
   "grouping.grouphashmetadata.event_hashing_metadata.stacktrace": {
     "chained_exception": "False",
     "stacktrace_location": "exception",
-    "stacktrace_type": "in_app"
+    "stacktrace_type": "system"
   }
 }
 ---
 contributing variants:
-  app*
+  system*
     hash: "fe92cff6711f8a0a30cabb8b9245b1d6"
     contributing component: exception
     component:
-      app*
+      system*
         exception*
           stacktrace*
-            frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+            frame* (marked out of app by stack trace rule (function:handleRequest -app +group))
               filename*
                 "router.js"
               function*

diff --git a/...test_metadata_from_variants/newstyle@2019_10_29/contributing_system_and_app_frames.pysnap b/...test_metadata_from_variants/newstyle@2019_10_29/contributing_system_and_app_frames.pysnap
@@ -1,5 +1,5 @@
 ---
-created: '2025-01-30T21:41:01.822552+00:00'
+created: '2025-01-30T21:46:13.738334+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_grouphash_metadata.py
 ---
@@ -24,13 +24,29 @@ metrics with tags: {
 ---
 contributing variants:
   app*
-    hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+    hash: "161ce02ecc5d6685a72e8e520ab726b3"
     contributing component: exception
     component:
       app*
         exception*
           stacktrace*
-            frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+            frame* (marked in-app by stack trace rule (function:playFetch +app +group))
+              filename*
+                "dogpark.js"
+              function*
+                "playFetch"
+              context-line*
+                "raise FailedToFetchError('Charlie didn't bring the ball back!');"
+          type*
+            "FailedToFetchError"
+  system*
+    hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+    contributing component: exception
+    component:
+      system*
+        exception*
+          stacktrace*
+            frame* (marked out of app by stack trace rule (function:handleRequest -app +group))
               filename*
                 "router.js"
               function*

diff --git a/...etadata/test_metadata_from_variants/newstyle@2019_10_29/contributing_system_frames.pysnap b/...etadata/test_metadata_from_variants/newstyle@2019_10_29/contributing_system_frames.pysnap
@@ -1,13 +1,13 @@
 ---
-created: '2025-01-30T21:41:01.889599+00:00'
+created: '2025-01-30T21:46:13.879780+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_grouphash_metadata.py
 ---
 hash_basis: stacktrace
 hashing_metadata: {
   "num_stacktraces": 1,
   "stacktrace_location": "exception",
-  "stacktrace_type": "in_app"
+  "stacktrace_type": "system"
 }
 ---
 metrics with tags: {
@@ -18,19 +18,19 @@ metrics with tags: {
   "grouping.grouphashmetadata.event_hashing_metadata.stacktrace": {
     "chained_exception": "False",
     "stacktrace_location": "exception",
-    "stacktrace_type": "in_app"
+    "stacktrace_type": "system"
   }
 }
 ---
 contributing variants:
-  app*
+  system*
     hash: "fe92cff6711f8a0a30cabb8b9245b1d6"
     contributing component: exception
     component:
-      app*
+      system*
         exception*
           stacktrace*
-            frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+            frame* (marked out of app by stack trace rule (function:handleRequest -app +group))
               filename*
                 "router.js"
               function*

diff --git a/...test_metadata_from_variants/newstyle@2023_01_11/contributing_system_and_app_frames.pysnap b/...test_metadata_from_variants/newstyle@2023_01_11/contributing_system_and_app_frames.pysnap
@@ -1,5 +1,5 @@
 ---
-created: '2025-01-30T21:40:46.962385+00:00'
+created: '2025-01-30T21:46:37.831164+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_grouphash_metadata.py
 ---
@@ -24,13 +24,29 @@ metrics with tags: {
 ---
 contributing variants:
   app*
-    hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+    hash: "161ce02ecc5d6685a72e8e520ab726b3"
     contributing component: exception
     component:
       app*
         exception*
           stacktrace*
-            frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+            frame* (marked in-app by stack trace rule (function:playFetch +app +group))
+              filename*
+                "dogpark.js"
+              function*
+                "playFetch"
+              context-line*
+                "raise FailedToFetchError('Charlie didn't bring the ball back!');"
+          type*
+            "FailedToFetchError"
+  system*
+    hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+    contributing component: exception
+    component:
+      system*
+        exception*
+          stacktrace*
+            frame* (marked out of app by stack trace rule (function:handleRequest -app +group))
               filename*
                 "router.js"
               function*

diff --git a/...etadata/test_metadata_from_variants/newstyle@2023_01_11/contributing_system_frames.pysnap b/...etadata/test_metadata_from_variants/newstyle@2023_01_11/contributing_system_frames.pysnap
@@ -1,13 +1,13 @@
 ---
-created: '2025-01-30T21:40:47.031377+00:00'
+created: '2025-01-30T21:46:37.985114+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_grouphash_metadata.py
 ---
 hash_basis: stacktrace
 hashing_metadata: {
   "num_stacktraces": 1,
   "stacktrace_location": "exception",
-  "stacktrace_type": "in_app"
+  "stacktrace_type": "system"
 }
 ---
 metrics with tags: {
@@ -18,19 +18,19 @@ metrics with tags: {
   "grouping.grouphashmetadata.event_hashing_metadata.stacktrace": {
     "chained_exception": "False",
     "stacktrace_location": "exception",
-    "stacktrace_type": "in_app"
+    "stacktrace_type": "system"
   }
 }
 ---
 contributing variants:
-  app*
+  system*
     hash: "fe92cff6711f8a0a30cabb8b9245b1d6"
     contributing component: exception
     component:
-      app*
+      system*
         exception*
           stacktrace*
-            frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+            frame* (marked out of app by stack trace rule (function:handleRequest -app +group))
               filename*
                 "router.js"
               function*

diff --git a/...nts/test_event_hash_variant/newstyle@2019_05_08/contributing_system_and_app_frames.pysnap b/...nts/test_event_hash_variant/newstyle@2019_05_08/contributing_system_and_app_frames.pysnap
@@ -1,10 +1,10 @@
 ---
-created: '2025-01-30T21:38:17.979729+00:00'
+created: '2025-01-30T21:48:30.179389+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_variants.py
 ---
 app:
-  hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+  hash: "161ce02ecc5d6685a72e8e520ab726b3"
   contributing component: exception
   component:
     app*
@@ -17,7 +17,7 @@ app:
               "runApp"
             context-line*
               "return server.serve(port);"
-          frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+          frame (non app frame)
             filename*
               "router.js"
             function*
@@ -44,11 +44,11 @@ app:
           "FailedToFetchError: Charlie didn't bring the ball back!"
 --------------------------------------------------------------------------
 system:
-  hash: null
-  contributing component: null
+  hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+  contributing component: exception
   component:
-    system (exception of app takes precedence)
-      exception (ignored because hash matches app variant)
+    system*
+      exception*
         stacktrace*
           frame (ignored by stack trace rule (function:runApp -app -group))
             filename*

diff --git a/...st_variants/test_event_hash_variant/newstyle@2019_05_08/contributing_system_frames.pysnap b/...st_variants/test_event_hash_variant/newstyle@2019_05_08/contributing_system_frames.pysnap
@@ -1,23 +1,23 @@
 ---
-created: '2025-01-30T21:38:18.144167+00:00'
+created: '2025-01-30T21:48:30.270003+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_variants.py
 ---
 app:
-  hash: "fe92cff6711f8a0a30cabb8b9245b1d6"
-  contributing component: exception
+  hash: null
+  contributing component: null
   component:
-    app*
-      exception*
-        stacktrace*
+    app (exception of system takes precedence)
+      exception (ignored because this variant does not have a contributing stacktrace, but the system variant does)
+        stacktrace (ignored because it contains no contributing frames)
           frame (marked out of app by stack trace rule (function:runApp -app -group))
             filename*
               "app.js"
             function*
               "runApp"
             context-line*
               "return server.serve(port);"
-          frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+          frame (non app frame)
             filename*
               "router.js"
             function*
@@ -33,15 +33,15 @@ app:
               "return withMetrics(handler, metricName, tags);"
         type*
           "FailedToFetchError"
-        value (ignored because stacktrace takes precedence)
+        value*
           "FailedToFetchError: Charlie didn't bring the ball back!"
 --------------------------------------------------------------------------
 system:
-  hash: null
-  contributing component: null
+  hash: "fe92cff6711f8a0a30cabb8b9245b1d6"
+  contributing component: exception
   component:
-    system (exception of app takes precedence)
-      exception (ignored because hash matches app variant)
+    system*
+      exception*
         stacktrace*
           frame (ignored by stack trace rule (function:runApp -app -group))
             filename*

diff --git a/...nts/test_event_hash_variant/newstyle@2019_10_29/contributing_system_and_app_frames.pysnap b/...nts/test_event_hash_variant/newstyle@2019_10_29/contributing_system_and_app_frames.pysnap
@@ -1,10 +1,10 @@
 ---
-created: '2025-01-30T21:37:56.171192+00:00'
+created: '2025-01-30T21:48:09.575427+00:00'
 creator: sentry
 source: tests/sentry/grouping/test_variants.py
 ---
 app:
-  hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+  hash: "161ce02ecc5d6685a72e8e520ab726b3"
   contributing component: exception
   component:
     app*
@@ -17,7 +17,7 @@ app:
               "runApp"
             context-line*
               "return server.serve(port);"
-          frame* (un-ignored by stack trace rule (function:handleRequest -app +group))
+          frame (non app frame)
             filename*
               "router.js"
             function*
@@ -44,11 +44,11 @@ app:
           "FailedToFetchError: Charlie didn't bring the ball back!"
 --------------------------------------------------------------------------
 system:
-  hash: null
-  contributing component: null
+  hash: "c5e4b4a9ad1803c4d4ca7feee5e430ae"
+  contributing component: exception
   component:
-    system (exception of app takes precedence)
-      exception (ignored because hash matches app variant)
+    system*
+      exception*
         stacktrace*
           frame (ignored by stack trace rule (function:runApp -app -group))
             filename*