Clean up impossible test conditions and fix broken CI #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
changed the title
ste93cry
force-pushed
the
cleanup-impossible-test-condition
branch
from
eeee210 to
9771e1a
Compare
Jean85
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the new release of
symfony/psr-http-message-bridge, the return type ofHttpMessageFactoryInterface::createRequest()was added at language-level. This triggered PHPStan and PHPUnit to report thatnullcannot be returned from such method, but an assertion of a test case was expecting that it happened. This PR refactors the broken tests by cleaning up the conditions that cannot happen in real life.In addition to this, an error message from PHPStan was updated and no longer matched our baseline. Finally, I also fixed some deprecations that were breaking the end-to-end tests after the release of Symfony
6.4