Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs for PHP 8.3 to the CI #767

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add jobs for PHP 8.3 to the CI #767

merged 3 commits into from
Oct 25, 2023

Conversation

ste93cry
Copy link
Collaborator

@ste93cry ste93cry commented Oct 22, 2023

With PHP 8.3 coming in November 2023, it's time to run the CI for that version as well so that we're ready for its release.

.github/workflows/static-analysis.yaml Outdated Show resolved Hide resolved
@ste93cry ste93cry force-pushed the support-php-version-8.3 branch from 503edfc to 03f39c1 Compare October 24, 2023 21:04
@ste93cry
Copy link
Collaborator Author

@cleptric I think it's pointless to retest all PHP versions just to make sure they work without optional packages installed, so I removed some jobs from the GitHub Workflow and changed the matrix so that only the oldest and newest PHP versions of each major are tested. However, as you can see from the following image, some jobs are still flagged as required checks for the CI to pass. Maybe the repo settings need to be adjusted accordingly?

immagine

@cleptric
Copy link
Member

The required checks haven been removed.

@ste93cry ste93cry requested a review from Jean85 October 25, 2023 10:00
@ste93cry ste93cry merged commit 39c3d97 into master Oct 25, 2023
30 checks passed
@ste93cry ste93cry deleted the support-php-version-8.3 branch October 25, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants