Add Ruby 3.3 to CI matrix #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -13,15 +13,21 @@ concurrency: | |||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |||
| cancel-in-progress: true | |||
| jobs: | |||
| ruby-versions: | |||
| uses: ruby/actions/.github/workflows/ruby_versions.yml@master | |||
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2208 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 101 101
Lines 3799 3799
=======================================
Hits 3700 3700
Misses 99 99
|
st0012
force-pushed
the
update-ci-ruby-versions
branch
from
b35a6b4 to
2a572fa
Compare
| @@ -13,6 +13,11 @@ concurrency: | |||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |||
| cancel-in-progress: true | |||
| jobs: | |||
| ruby-versions: | |||
| uses: ruby/actions/.github/workflows/ruby_versions.yml@master | |||
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| @@ -13,6 +13,11 @@ concurrency: | |||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |||
| cancel-in-progress: true | |||
| jobs: | |||
| ruby-versions: | |||
| uses: ruby/actions/.github/workflows/ruby_versions.yml@master | |||
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| @@ -13,6 +13,11 @@ concurrency: | |||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |||
| cancel-in-progress: true | |||
| jobs: | |||
| ruby-versions: | |||
| uses: ruby/actions/.github/workflows/ruby_versions.yml@master | |||
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
st0012
force-pushed
the
update-ci-ruby-versions
branch
from
2a572fa to
c5e3ad5
Compare
st0012
changed the title
For these gems' CI, using the ruby_versions action will make the Ruby version matrix slightly easier to maintain.
st0012
force-pushed
the
update-ci-ruby-versions
branch
from
c5e3ad5 to
3aaa68d
Compare
sl0thentr0py
approved these changes
Dec 28, 2023
|
you can ignore danger about those pins |
|
@sl0thentr0py I feel that rule is a bit annoying and we basically just ignore it. Is there a way we can skip it? |
|
no i already asked for it and they said no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby_versionsworkflow will save us from manually updating Ruby matrix in the future, a minor improvement.ruby_versionseasily to sentry-rails & sentry-sidekiq as they have rather complicated Ruby vs lib version mapping.#skip-changelog