Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flutter): document how to add data to spans/transactions #12367

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

buenaflor
Copy link
Contributor

DESCRIBE YOUR PR

Closes getsentry/sentry-dart#2554

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@buenaflor buenaflor requested a review from kahest January 16, 2025 12:10
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 2:26pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:26pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:26pm

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding! left some small-ish suggestions

platform-includes/performance/improving-data/dart.mdx Outdated Show resolved Hide resolved
platform-includes/performance/improving-data/dart.mdx Outdated Show resolved Hide resolved
platform-includes/performance/improving-data/dart.mdx Outdated Show resolved Hide resolved
Co-authored-by: Karl Heinz Struggl <[email protected]>
Copy link

codecov bot commented Jan 16, 2025

Bundle Report

Changes will increase total bundle size by 189 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 195 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a few suggestions that I think help reduce repeated content.

@buenaflor buenaflor enabled auto-merge (squash) January 20, 2025 14:01
@buenaflor buenaflor merged commit 7de987d into master Jan 20, 2025
10 checks passed
@buenaflor buenaflor deleted the feat/doc-span-data branch January 20, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to attach data onto a span/transaction
3 participants