-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable options.debug
when in debug mode
#2597
Conversation
options.debug
when in debug mode
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Enable `options.debug` when in debug mode ([#2597](https://github.com/getsentry/sentry-dart/pull/2597)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
==========================================
+ Coverage 75.75% 78.37% +2.61%
==========================================
Files 26 35 +9
Lines 1287 1489 +202
==========================================
+ Hits 975 1167 +192
- Misses 312 322 +10 ☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be8cafe | 1239.94 ms | 1266.20 ms | 26.27 ms |
05933ac | 1258.37 ms | 1285.57 ms | 27.21 ms |
464b4d0 | 1249.02 ms | 1261.22 ms | 12.20 ms |
c1951de | 1238.51 ms | 1251.88 ms | 13.37 ms |
1131914 | 1277.20 ms | 1300.20 ms | 23.00 ms |
9ed26e6 | 1263.84 ms | 1281.04 ms | 17.20 ms |
0be962b | 1264.10 ms | 1281.16 ms | 17.06 ms |
ad69abc | 1259.00 ms | 1261.60 ms | 2.60 ms |
04211b9 | 1253.35 ms | 1283.25 ms | 29.90 ms |
d53c6fa | 1254.86 ms | 1270.83 ms | 15.97 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be8cafe | 8.33 MiB | 9.40 MiB | 1.07 MiB |
05933ac | 8.38 MiB | 9.78 MiB | 1.40 MiB |
464b4d0 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
c1951de | 8.42 MiB | 9.83 MiB | 1.40 MiB |
1131914 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
9ed26e6 | 8.42 MiB | 9.89 MiB | 1.46 MiB |
0be962b | 8.10 MiB | 9.16 MiB | 1.07 MiB |
ad69abc | 8.10 MiB | 9.08 MiB | 1004.37 KiB |
04211b9 | 8.38 MiB | 9.78 MiB | 1.41 MiB |
d53c6fa | 8.29 MiB | 9.39 MiB | 1.10 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! pls also update the debug flag in the docs, will approve once the docs pr is out
can be merged now 👍 I'll merge the docs when the non-preview release is out |
📜 Description
💡 Motivation and Context
Closes #2561
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled