Remove metrics API #2571
Merged
Remove metrics API #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
+ Coverage 87.29% 88.96% +1.66%
==========================================
Files 268 262 -6
Lines 9342 8950 -392
==========================================
- Hits 8155 7962 -193
+ Misses 1187 988 -199 ☔ View full report in Codecov by Sentry. |
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
buenaflor
commented
Jan 14, 2025
vaind
approved these changes
Jan 14, 2025
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ca7f531 | 395.69 ms | 497.82 ms | 102.12 ms |
| 3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
| 0aaa46e | 313.39 ms | 373.23 ms | 59.85 ms |
| affcf07 | 446.19 ms | 476.32 ms | 30.13 ms |
| abfcdb5 | 416.55 ms | 498.88 ms | 82.33 ms |
| a775d3f | 359.58 ms | 436.68 ms | 77.10 ms |
| e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
| b9da046 | 393.00 ms | 455.52 ms | 62.52 ms |
| fe4aa56 | 356.06 ms | 428.67 ms | 72.61 ms |
| 6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ca7f531 | 6.33 MiB | 7.26 MiB | 949.75 KiB |
| 3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 0aaa46e | 6.16 MiB | 7.14 MiB | 1007.32 KiB |
| affcf07 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| abfcdb5 | 6.35 MiB | 7.40 MiB | 1.05 MiB |
| a775d3f | 6.27 MiB | 7.20 MiB | 957.75 KiB |
| e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| b9da046 | 6.06 MiB | 7.03 MiB | 990.30 KiB |
| fe4aa56 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 202b83f | 1206.16 ms | 1225.33 ms | 19.16 ms |
| 6aab859 | 1245.14 ms | 1247.59 ms | 2.45 ms |
| be1723a | 1253.31 ms | 1267.36 ms | 14.06 ms |
| 0a23f98 | 1252.98 ms | 1276.76 ms | 23.78 ms |
| 134c9f8 | 1284.48 ms | 1306.18 ms | 21.70 ms |
| 7d5e695 | 1230.20 ms | 1265.40 ms | 35.20 ms |
| 732a7b4 | 1242.17 ms | 1266.96 ms | 24.79 ms |
| 873fb42 | 1261.00 ms | 1285.92 ms | 24.92 ms |
| 64e4616 | 1242.80 ms | 1270.07 ms | 27.27 ms |
| fec92cc | 1237.93 ms | 1259.21 ms | 21.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 202b83f | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 6aab859 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| be1723a | 8.38 MiB | 9.77 MiB | 1.39 MiB |
| 0a23f98 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 134c9f8 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 7d5e695 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
| 732a7b4 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| 873fb42 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 64e4616 | 8.28 MiB | 9.34 MiB | 1.05 MiB |
| fec92cc | 8.33 MiB | 9.54 MiB | 1.22 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing public API is usually done in majors but metrics was in beta before and the product is completely shut down so it's just dead code at this point
Closes #2560