forked from rrweb-io/rrweb
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set style properties directly in mutation #211
Draft
chargome
wants to merge
3
commits into
sentry-v2
Choose a base branch
from
cg/fix-csp-errors
base: sentry-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ | |
'now you can use replayer.getMirror() to access the mirror instance of a replayer,' + | ||
'\r\n' + | ||
'or you can use record.mirror to access the mirror instance during recording.'; | ||
/** @deprecated */ | ||
Check warning on line 37 in packages/rrweb/src/utils.ts GitHub Actions / ESLint Report Analysispackages/rrweb/src/utils.ts#L37
|
||
export let _mirror: DeprecatedMirror = { | ||
map: {}, | ||
getId() { | ||
|
@@ -118,7 +118,7 @@ | |
set(value) { | ||
// put hooked setter into event loop to avoid of set latency | ||
setTimeout(() => { | ||
d.set!.call(this, value); | ||
}, 0); | ||
if (original && original.set) { | ||
original.set.call(this, value); | ||
|
@@ -131,7 +131,7 @@ | |
|
||
// copy from https://github.com/getsentry/sentry-javascript/blob/b2109071975af8bf0316d3b5b38f519bdaf5dc15/packages/utils/src/object.ts | ||
export function patch( | ||
source: { [key: string]: any }, | ||
name: string, | ||
replacement: (...args: unknown[]) => unknown, | ||
): () => void { | ||
|
@@ -670,3 +670,28 @@ | |
): ReturnType<typeof window.clearTimeout> { | ||
return getImplementation('clearTimeout')(...rest); | ||
} | ||
|
||
/** | ||
* Takes a styles attribute string and converts it to key value pairs | ||
* @param styles - The full styles attributes string | ||
* | ||
*/ | ||
export function splitStyleAttributes(styles: string) { | ||
const splitStyles = styles.split(';'); | ||
return splitStyles | ||
.filter((value) => value.split(':').length == 2) | ||
.map((style) => { | ||
let [property, value] = style.trim().split(':'); | ||
|
||
property = property.trim(); | ||
value = value.trim(); | ||
|
||
// Convert kebab-case to camelCase | ||
const camelCasedProperty = property.replace( | ||
/-([a-z])/g, | ||
(match, letter: string) => letter.toUpperCase(), | ||
); | ||
|
||
return { property: camelCasedProperty, value }; | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Is this safe? Could styles not include colons in other places? Not 100% sure, just want to double check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will probably be an issue sooner or later, you're right