upstream: Add config option to turn off all snapshotting and related observers #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rweb-io#1311) * Add config option to turn off all snapshotting and related observers - allows RRWEB to be used for click/movement tracking alone, e.g. for a heatmaps use case - could also be used if there was a separate process for recording the DOM (in which case a 3rd party library like https://github.com/antonmedv/finder could be added to record targets instead of the mirror) --------- Authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
size-limit report 📦
|
billyvg
changed the title
|
Ref rrweb-io#1311 |
c298lee
reviewed
Jan 31, 2024
| if (o.recordDOM) { | ||
| styleSheetObserver = initStyleSheetObserver(o, { win: currentWindow }); | ||
| adoptedStyleSheetObserver = initAdoptedStyleSheetObserver(o, o.doc); | ||
| styleDeclarationObserver = initStyleDeclarationObserver(o, { |
There was a problem hiding this comment.
Same thing as https://github.com/getsentry/rrweb/pull/163/files#diff-b7a42c375ac5ab2de196b5e95e0b2f82b723969c5836fac0ff6f7ca6ad66ebd7L1306 except this observer only runs when o.recordDOM is true
c298lee
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-by: eoghanmurray [email protected]
Co-authored-by: Justin Halsall [email protected]