Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #751: add package_data #752

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

YonatanGreenfeld
Copy link
Contributor

fix #751

In the PR the include_package_data flag was removed from setup.py.
This caused the py.typed marker file to also be removed, resulting in mypy errors:

Skipping analyzing "responses": module is installed, but missing library stubs or py.typed marker  [import-untyped]

Using package_data we can pick specific files instead of everything (which was the motive for the latest change).

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@markstory markstory merged commit da4e965 into getsentry:master Jan 13, 2025
16 checks passed
@markstory
Copy link
Member

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.25.5 dropped py.typed file breaking mypy type checking
2 participants