feat: stencil #99
Merged
feat: stencil #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stencil to use the latest version of Go.
| // Uses a combination of built-in slog and olog functionality to | ||
| // provide a standard, structured logging interface and implementation. | ||
| // *slog.Logger instance are concurrency safe. | ||
| var log *slog.Logger = olog.New() |
AndrewWinterman
approved these changes
May 24, 2024
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@asms @AndrewWinterman FYI, this is a breaking change which basically requires everything that depends on this library to be refactored in a non-trivial manner. This should have been a major version bump. Alternatively, there could have been a new function that uses The release notes for 1.15.0 are also incomplete. If you're going to make a breaking API change, at minimum please update the release notes accordingly instead of making consumers read your PR to figure out what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The purpose of this PR is to be able to use this library for accessing the production Vault server. This can be seen in the second commit of this PR. This first commit is just an auxiliary restencil.
Re-stencil the repo to update to a newer version of Go which supports log/slog.
Update the interface of
EnsureLoggedInandIsLoggedInto remove logrus, in favor of olog/slog, and to remove the dependency on box configs, which are specific to devenv.