forked from okta/okta-aws-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync upstream #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
through the device auth loop again. Closes okta#118
Cached Access Token retry
preparing 1.2.2 release
Add Semgrep
README driven design
stub out m2m subcommand
M2M Access Token
Update release.yml to allow builds off m2m_feature branch
Fetching IAM creds with assume role with web identity
required backporting from other CLIs ... Closes okta#142
AWS Region CLI flag `--aws-region`
Bringing in MatthewJohn's PR okta#162 - multiple config profiles in okta.yaml
`noop` format option wasn't listed in the CLI help text.
Update root.go
Fix bug where all flags were not being set on the config object.
we'll reverse look up the ARN value for them from okta.yaml. Closes okta#102
`--aws-iam-idp` and `--aws-iam-role` alias values
v2.1.0 release
Remove reference to old flag `--debug-config` which is now a subcommand `debug`. Closes okta#180
…uments in README examples. Closes okta#183
Update README.md
Improve explanation of default commands.
…ng AWS profiles in Okta config. Fix logic that determines if the AWS-profile-specific config key has been set - viper InConfig and IsSet appear to always return true, even if the value is not defined in the "profile.key" Fixes okta#182
MatthewJohn's PR 187
v2.1.1 release
malept
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it upgrades to v2.1.1 so I'm blocking this. We shouldn't need to fork for 2.x versions.
I am going to upgrade to the latest v1 then so we can get some of the bug fixes it includes. |
Closing this out and updating 1.2.2 in #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.