Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync upstream #3

Closed
wants to merge 120 commits into from
Closed

chore: sync upstream #3

wants to merge 120 commits into from

Conversation

pbr0ck3r
Copy link

No description provided.

monde and others added 30 commits August 30, 2023 16:00
Update release.yml to allow builds off m2m_feature branch
Fetching IAM creds with assume role with web identity
MatthewJohn and others added 25 commits February 12, 2024 15:12
AWS Region CLI flag `--aws-region`
Bringing in MatthewJohn's PR okta#162 - multiple config profiles in okta.yaml
`noop` format option wasn't listed in the CLI help text.
Fix bug where all flags were not being set on the config object.
we'll reverse look up the ARN value for them from okta.yaml.

Closes okta#102
`--aws-iam-idp` and `--aws-iam-role` alias values
Remove reference to old flag `--debug-config` which is now a subcommand `debug`.

Closes okta#180
Improve explanation of default commands.
…ng AWS profiles in Okta config.

Fix logic that determines if the AWS-profile-specific config key has been set - viper InConfig and IsSet appear to always return true, even if the value is not defined in the "profile.key"

Fixes okta#182
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it upgrades to v2.1.1 so I'm blocking this. We shouldn't need to fork for 2.x versions.

@pbr0ck3r
Copy link
Author

I am going to upgrade to the latest v1 then so we can get some of the bug fixes it includes.

@pbr0ck3r
Copy link
Author

Closing this out and updating 1.2.2 in #4

@pbr0ck3r pbr0ck3r closed this Feb 26, 2024
@pbr0ck3r pbr0ck3r deleted the pbr0ck3r/chore/update-fork branch February 26, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants