feat: Moving to go 1.23, fixing .tool-versions/settings.json #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredallard
reviewed
Aug 18, 2024
malept
reviewed
Jan 14, 2025
Comment on lines
-37
to
-42
| "[terraform]": { | ||
| "editor.defaultFormatter": "hashicorp.terraform" | ||
| }, | ||
| "protoc": { | ||
| "options": ["--proto_path=${workspaceRoot}/api"] | ||
| } |
There was a problem hiding this comment.
This is going to get re-added when stencil is re-run
malept
reviewed
Jan 14, 2025
| # Note: Versions in this block do not override the default versions above | ||
| # but sometimes you have to declare additional versions of the same tool | ||
| # while leaving the 'default' version intact for the infra. | ||
| # The most common case is nodejs. | ||
| ## <<Stencil::Block(toolver)>> | ||
| mage 1.14.0 |
There was a problem hiding this comment.
I'm generally not inclined to add this because it's already here:
|
Closing in favor of #142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes lintroller for folks who have upgraded to go 1.23 and getting errors like this:
I also fixed up the tool-versions/settings.json that are unnecessarily pulling in protoc/terraform modules