feat: upgrade to yarn v4 #666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredallard
force-pushed
the
jaredallard/feat/latest-yarn
branch
from
cb56150 to
7101975
Compare
jaredallard
added a commit
to getoutreach/stencil-base
that referenced
this pull request
Sep 21, 2023
Upgrades to using yarn v3. Relies on getoutreach/devbase#666
jaredallard
force-pushed
the
jaredallard/feat/latest-yarn
branch
from
7101975 to
e1f36d9
Compare
Upgrades to `yarn` v3. Changes the installation method from `npm` to `corepack`, which is the recommended way to install yarn[^1]. Migrates `devbase` to use v3 of `yarn`, a follow up PR to stencil-base will change the `package.json` and `.gitignore`. [^1]: https://yarnpkg.com/getting-started/install
jaredallard
force-pushed
the
jaredallard/feat/latest-yarn
branch
from
e1f36d9 to
a864af5
Compare
jaredallard
added a commit
to getoutreach/stencil-base
that referenced
this pull request
Sep 21, 2023
Upgrades to using yarn v3. Relies on getoutreach/devbase#666
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Checks the global npm registry for `yarn`, if it exists we uninstall it.
This comment was marked as outdated.
This comment was marked as outdated.
|
Not sure if I like the asdf versions display I added in this PR, I'll probably make it so it only runs on the setup environment step. Otherwise, it seems like it could pollute CI in other places (see logs) |
jaredallard
force-pushed
the
jaredallard/feat/latest-yarn
branch
from
7403ccc to
21b017a
Compare
jaredallard
force-pushed
the
jaredallard/feat/latest-yarn
branch
from
21b017a to
0e7b492
Compare
jaredallard
commented
Sep 22, 2023
| @@ -18,5 +18,5 @@ validate-orb: build-orb | |||
|
|
|||
| .PHONY: publish-orb | |||
| publish-orb: validate-orb | |||
| circleci orb publish orb.yml getoutreach/shared@dev:first | |||
| circleci orb publish orb.yml getoutreach/shared@dev:jaredallard-feat-yarn-v3 | |||
There was a problem hiding this comment.
Reset before merge.
jaredallard
commented
Sep 22, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Updates cache paths to have better uniformity as well as use `yarn.lock` to handle lockfile-only changes.
jaredallard
force-pushed
the
jaredallard/feat/latest-yarn
branch
from
140d3d5 to
af40bf0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jaredallard
added a commit
to getoutreach/stencil-golang
that referenced
this pull request
Sep 22, 2023
Upgrades the node client to use `yarn` v3. Depends on the following PRs: * getoutreach/devbase#666 * getoutreach/stencil-base#139
jaredallard
commented
Sep 22, 2023
| @@ -2,7 +2,7 @@ | |||
| # syntax, such as anchors, will be fixed automatically. | |||
| version: 2.1 | |||
| orbs: | |||
| shared: getoutreach/shared@2.19.2 | |||
| shared: getoutreach/shared@dev:jaredallard-feat-yarn-v3 | |||
There was a problem hiding this comment.
Change back to dev:first before merging (publish to dev:first before merging locally)
jaredallard
commented
Sep 22, 2023
| @@ -3,4 +3,4 @@ steps: | |||
| - run: | |||
| name: Build Node Client | |||
| working_directory: api/clients/node/ | |||
| command: yarn --frozen-lockfile build | |||
There was a problem hiding this comment.
--frozen-lockfile isn't required when running scripts now.
jaredallard
commented
Sep 22, 2023
| - run: | ||
| name: Install semantic-release Dependencies | ||
| command: yarn --frozen-lockfile | ||
| command: yarn --immutable |
There was a problem hiding this comment.
--frozen-lockfile was replaced by --immutable
jaredallard
commented
Sep 22, 2023
| @@ -7,15 +7,6 @@ source "$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)/../lib/she | |||
| yarn_install_if_needed() { | |||
| local stateFile="node_modules/devbase.lock" | |||
|
|
|||
| if ! yarn -v >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
Duplicative code, we do this as part of setup_environment, which calls ensure_asdf, which is ran on local machines and CI.
jaredallard
commented
Sep 22, 2023
| @@ -15,12 +15,18 @@ if [[ -z $asdf_plugins_list ]]; then | |||
| asdf_plugins_list_regenerate | |||
| fi | |||
|
|
|||
| # asdf_find_tool_versions returns all .tool-version files that could | |||
| # be used in the current repository. | |||
| asdf_find_tool_versions() { | |||
There was a problem hiding this comment.
Split out to enable asdf_display_versions
jaredallard
commented
Sep 22, 2023
| @@ -11,13 +11,13 @@ extensions=(yaml yml json md ts) | |||
|
|
|||
| prettier_linter() { | |||
| yarn_install_if_needed >/dev/null | |||
| find_files_with_extensions "${extensions[@]}" | xargs -n40 "node_modules/.bin/prettier" -l --loglevel log | |||
There was a problem hiding this comment.
node_modules/.bin isn't a thing in pnpm linking. yarn run <script> has always supported doing this for us, so this is more clean this way anyways.
|
Link to code coverage report (posted by coverbot 🤖) |
jaredallard
added a commit
to getoutreach/stencil-golang
that referenced
this pull request
Nov 2, 2023
Upgrades the node client to use `yarn` v4. Depends on the following PRs: * getoutreach/devbase#666 * getoutreach/stencil-base#139
|
Link to code coverage report (posted by coverbot 🤖) |
jaredallard
added a commit
to getoutreach/stencil-base
that referenced
this pull request
Nov 2, 2023
Upgrades to using yarn v4. Relies on getoutreach/devbase#666
jaredallard
added a commit
to getoutreach/stencil-base
that referenced
this pull request
Nov 2, 2023
Upgrades to using yarn v4. Relies on getoutreach/devbase#666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to
yarnv4. Changes the installation method fromnpmtocorepack, which is the recommended way to install yarn1.Migrates
devbaseto use v4 ofyarn, changes some templates toenable this:
Added a
asdf_display_versionsfunction tolib/asdf.shthat shows thecurrent tools and their relevant versions in use. This is displayed during
the
setup_environmentstep of CI.Footnotes
https://yarnpkg.com/getting-started/install ↩