Access permissions 6: Complete test cases #6882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
approved these changes
Jan 8, 2025
lukasbestle
force-pushed
the
v5/feature/access-permissions-5
branch
2 times, most recently
from
3ae8380 to
1800a69
Compare
We have added these permissions since creating these tests and seem to have forgotten to add them here as well
lukasbestle
force-pushed
the
v5/feature/access-permissions-6
branch
from
8c875b9 to
be4a995
Compare
Base automatically changed from
v5/feature/access-permissions-5
to
v5/develop
January 21, 2025 17:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Merge first
Description
Summary of changes
Add missing provider cases for existing permissions
Reasoning
We have added these permissions since creating these tests and seem to have forgotten to add them here as well.
Additional context
Clearing the cache is needed for
PageBlueprinttests because we reuse the same blueprint names with different options. Ideally we would clear the cache after every test in theCmsnamespace, but for some reason many test classes inherit fromKirby\TestCaseinstead ofKirby\Cms\TestCase, thus making it hard to find a good place for this.Changelog
None (too small of a change to be relevant)
Docs
None
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)Add changes & docs to release notes draft in Notion