Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 16: ModelWithContent simplifications #6505

Merged

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jun 25, 2024

This PR …

Reasoning

I'm trying to already use the improvements and changes from the last PRs in ModelWithContent without taking too many steps at once. The full conversion will be still a lot of complicated, potentially breaking steps. Taking it easy will help to keep our mental load in check.

Refactoring

  • Simplify ModelWithContent::writeContent by using the new Version::save() method.
  • Simplify ModelWithContent::content by using Language::ensure() and Version::content()

Breaking changes

None expected

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier force-pushed the v5/changes/16-model-with-content-simplifications branch from 03acb08 to dae72e1 Compare June 25, 2024 08:50
@bastianallgeier bastianallgeier added this to the 5.0.0-alpha.2 milestone Jun 25, 2024
Base automatically changed from v5/changes/15-more-content-storage-handler-methods to v5/develop June 27, 2024 08:24
@bastianallgeier bastianallgeier marked this pull request as ready for review June 27, 2024 08:25
@bastianallgeier bastianallgeier merged commit b2748f7 into v5/develop Jun 27, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/16-model-with-content-simplifications branch June 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants