Filesystem\Mime: more readable if logic

[distantnative]

Description

Summary of changes

• Filesystem\Mime::toExtensions(): refactored nested if-else into one-level if

Reasoning

The nested if-else logic is super hard to read and keep track of the conditions for each result, which also does the same. Changing it to a one-level if is a lot easier to read, which various conditions lead to adding an extension, even if we have to list some conditions multiple times then.

Ready?

• In-code documentation (wherever needed)
• Tests and CI checks all pass

[lukasbestle]

TBH I think this is much harder to read, especially because the first two conditions in each group look the same at first glance and only differ by === false being present or not.

If we boil it down, it's basically a matrix of the $value type and the requested $matchWildcard mode. Maybe we could simplify it by using A::wrap() to get rid of half of the cases first.

We could further simplify it by using array_filter(). Its callback can then use early returns of true/false so that we can use one level of separate ifs.

[distantnative]

I disagree that it's harder to read. It takes such a mental load down in the second else clause to keep track of which conditions actually apply there. With that, this new explicitness would help a lot.

I agree that this still isn't "the yellow from the egg". I will have a stab at your suggestions, would be indeed great to improve this more.

[lukasbestle]

Much better 👍