Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Enhancement: srcset dimensions, data-* #1324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

d-oit
Copy link
Contributor

@d-oit d-oit commented Dec 20, 2024

  • feat: data/dimensions.yml: implement auto with defined width dimensions
  • feat: image short code dataAttributes to create data-* e.g.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit a8a46e9
🔍 Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/6765b60a88a8ad000843ee5a
😎 Deploy Preview https://deploy-preview-1324--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-oit
Copy link
Contributor Author

d-oit commented Dec 20, 2024

#1205
https://d-oit.github.io/en/blog/2024-11-13-enhanced-image-handling-on-d-oitgithubio/#key-changes

@markdumay
Created this pr first without the lightbox js.
Created a separate lightbox module with a gallery.html which needs these changes.
Would you like the lightbox in Hinode or a module?

@actuallynotjohndoe
Copy link

when is this going to be merged to main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants