fix: do not allow creating duplicate pending transactions #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there no constraint on the DB? A find will also not fully prevent a race condition. |
No. For example if you try to pay once and fail, and then pay and succeed, this will be two different entries
Here it's done within a database transaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally relied on the LNClient to not allow creating duplicate pending transactions, but there seems to be a race condition that allows the creation of two pending transactions in our transactions database. When the payment is settled, only one of the pending transactions is marked as sent, and the other is left pending, which creates issues with budgets and especially sub-wallets (the money is stuck and forever inaccessible)