Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboarding security page #1043

Merged
merged 6 commits into from
Jan 30, 2025
Merged

feat: onboarding security page #1043

merged 6 commits into from
Jan 30, 2025

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 29, 2025

Closes #842
Closes #823

Removes the TOS on the welcome screen and adds a new security page as the last step of the node creation process.

LDK & Cashu

image

LND & Phoenix

image

LDK (no Alby Account)

image

@MoritzKa
Copy link
Contributor

Thanks for removing the ToS.
On the LND & Phoenix page, we could remove "LND" from point 3 and just say: "Channel backups...." , because it is for both LND and Phoenix.

@rolznz
Copy link
Contributor Author

rolznz commented Jan 30, 2025

On the LND & Phoenix page, we could remove "LND" from point 3 and just say: "Channel backups...." , because it is for both LND and Phoenix.

@MoritzKa thanks, I will remove it. I indirectly was trying to hint that we only support channel backups on LDK which is probably useless. I changed it to this, what do you think?

image

@rolznz
Copy link
Contributor Author

rolznz commented Jan 30, 2025

I have made some minor copy improvements. We can iterate on this page over time.

@rolznz rolznz merged commit 79b9307 into master Jan 30, 2025
10 checks passed
@rolznz rolznz deleted the feat/onboarding-security-page branch January 30, 2025 16:48
@MoritzKa
Copy link
Contributor

@MoritzKa thanks, I will remove it. I indirectly was trying to hint that we only support channel backups on LDK which is probably useless. I changed it to this, what do you think?

Good point. We could mention both. "LND and Phoenixd channel backups are not handled ..."

But I like the suggestion: "...go back and choose the LDK node type." 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants