-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proposal: custom node commands #1007
Conversation
# Conflicts: # api/api.go # api/models.go # http/http_service.go # wails/wails_handlers.go
I've tested the updates, still seems to be working as before. I think the tests need to be improved a bit and then from my side it's good to merge 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
why did you not split the command and the arguments input? the we would not need to do the string parsing, would we?
We'd still have to split/parse the arguments, and it would also make the frontend responsible for splitting (since somebody's got to do it anyways 😄). So I figured I would keep the API as simple as possible by accepting a single command line. Alternatively, it is possible to make an API endpoint that would accept structured requests (with proper command and arg structures passed as JSON...) instead of raw commands, but again, that would require more complex frontend. |
Closes #965