Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qchat): no notification on self message mention #197

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix(qchat): no notification on self message mention #197

merged 2 commits into from
Sep 26, 2024

Conversation

gounux
Copy link
Member

@gounux gounux commented Sep 26, 2024

This PR avoids to send a QGIS message bar notification :

  • when a user mention him.her.self
  • when a user mention everybody with @all

Fix #195

@gounux gounux requested a review from Guts September 26, 2024 08:03
@github-actions github-actions bot added the UI User interface: forms, widgets... label Sep 26, 2024
@Guts Guts added the enhancement New feature or request label Sep 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gounux gounux merged commit fcf39ac into main Sep 26, 2024
10 checks passed
@gounux gounux deleted the fix/no-notif-on-self-mention branch September 26, 2024 10:51
@Guts Guts added bug Houston, we've got a problem... and removed enhancement New feature or request labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guts Guts Guts approved these changes

Assignees
No one assigned
Labels
bug Houston, we've got a problem... UI User interface: forms, widgets...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QChat: I should not be able to notify myself
2 participants
@gounux @Guts