#9583 unadvertised resources

[Igi-ID]

Description

This PR introduces the "Unadvertised" field on creation / edit of resources. Resources which are tagged as unadvertised are viewable and editable only by the owner or admin role users.

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Feature

Issue

What is the current behavior?
#9583 Unadvertised Resources

What is the new behavior?
The "Unadvertised" field is viewable and togglable inside the resource modal on creation/editing. Its value is processed and persisted and resources are filtered accordingly.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes, and I documented them in migration notes
• No

Other useful information

[offtherailz]

reviewed and tested 👍
@Igi-ID for your future work, take into account that only mandatory localization files are strictly requied (it,en,us,fr,de)

[offtherailz]

waiting for build to pass (there is a test that fails often and it should be taken into account @tdipisa , I opened an issue for this problem.

As well as deployed, please @ElenaGallo test on dev

[ElenaGallo]

Hi @Igi-ID @tdipisa,

If a map with unadvertised enabled and with group can edit, is opened by a user of the group on Save and Save as panel the Unadvertised checkbox is enable and it is possible to disable it. Is this behaviour correct?

edit.mp4

Open this map with a user in the geosolutions group

[tdipisa]

Hi @Igi-ID @tdipisa,

If a map with unadvertised enabled and with group can edit, is opened by a user of the group on Save and Save as panel the Unadvertised checkbox is enable and it is possible to disable it. Is this behaviour correct?

@ElenaGallo yes, see here for the AC clarification #9583 (comment) in respect of the usual MS overall model.

[tdipisa]

Just one thing I noticed @ElenaGallo @Igi-ID

If the unadvertised checkbox has been previously checked, when you open the map as a user without edit rights (e.g. logout with user with edit rights and then login again with a different user without edit rights), that checkbox is still checked in the Edit properties opening when clicking on the Save as button. The state should be reset, I think:

[Igi-ID]

Just one thing I noticed @ElenaGallo @Igi-ID

If the unadvertised checkbox has been previously checked, when you open the map as a user without edit rights (e.g. logout with user with edit rights and then login again with a different user without edit rights), that checkbox is still checked in the Edit properties opening when clicking on the Save as button. The state should be reset, I think:

Fix provided here #9984