#9368: adding support 3D tiles resources in catalog for CSW #9443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmoudadel54
added
enhancement
Good first issue
BackportNeeded
8 tasks
MV88
requested changes
Sep 15, 2023
… for testing 3d tiles in csw in test file
…romOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils
MV88
requested changes
Sep 18, 2023
|
@MV88 as agreed in our call, let's merge the PR as soon as the review is passed. We will proceed to test the solution early after by updating the involved downstream project. |
Desription:
Description: \n 1- Edit in function description in CoordinatesUtils. \n 2- Remove not needed cfg in localConfig
Description: \n - edit IT translation. \n - edit transformExtentToObj description/
MV88
approved these changes
Sep 18, 2023
|
@mahmoudadel54 (FYI @MV88) first test result reported a couple of things that need to be fixed.
This test has been performed by including this metadata template in the CSW source advanced configuration.
|
Since it is not related to the updated provided with this PR I've created a new issue to capture this (see #9461).
This need to be fixed as part of #9368 @mahmoudadel54 |
|
@mahmoudadel54 please backport this to 2023.02.xx. Thanks |
8 tasks
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Oct 15, 2023
…r CSW (geosolutions-it#9443) * geosolutions-it#9368: adding support 3D tiles resources in catalog for CSW * geosolutions-it#9368: enable reading metadata from csw for 3d tiles * geosolutions-it#9368: resolve comment of removing unneeded code in localConfig * geosolutions-it#9368: resovle comment: provide more generic test data for testing 3d tiles in csw in test file * geosolutions-it#9368: resolve comment about renaming 'getCesiumBoundFromOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils * resolving review changes Desription: * resolving review comments Description: \n 1- Edit in function description in CoordinatesUtils. \n 2- Remove not needed cfg in localConfig * resolve review comments Description: \n - edit IT translation. \n - edit transformExtentToObj description/
4 tasks
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Oct 16, 2023
…alog for CSW (#9599) * #9368: adding support 3D tiles resources in catalog for CSW (#9443) * #9368: adding support 3D tiles resources in catalog for CSW * #9368: enable reading metadata from csw for 3d tiles * #9368: resolve comment of removing unneeded code in localConfig * #9368: resovle comment: provide more generic test data for testing 3d tiles in csw in test file * #9368: resolve comment about renaming 'getCesiumBoundFromOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils * resolving review changes Desription: * resolving review comments Description: \n 1- Edit in function description in CoordinatesUtils. \n 2- Remove not needed cfg in localConfig * resolve review comments Description: \n - edit IT translation. \n - edit transformExtentToObj description/ * #9368: resolve test report comments (#9465) description: remove not needed span indicator for 3d layer in catalog sidebar+ remove all relevant translates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a support for 3D Tiles resources in CSW metadata.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9368
What is the current behavior?
adding CSW metadata in catalog doesn't support 3D Tiles if exists within it
#9368
What is the new behavior?
A support for 3D Tiles resources in CSW metadata is added and now user can add 3D tiles via CSW to the map.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information