#10663: fix adding decimals in the aeronautical form in searcg by coordinates #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - handle fixing the issue of prevent enters centesimal number after the comma/dot in aeronautical form and decimal form as well
Description: - add helpful comment
1 task
tdipisa
added
the
BackportNeeded
|
@mahmoudadel54 there is a failing tests that seems related to your contribution. Can you please check and fix it? Thank you so much. |
….jsx to fix FE failure
Fixing is done |
|
Test passed, @mahmoudadel54 please backport to 2024.02.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Nov 14, 2024
…n searcg by coordinates (geosolutions-it#10668) * geosolutions-it#10663: fix adding decimals in the aeronautical form Description: - handle fixing the issue of prevent enters centesimal number after the comma/dot in aeronautical form and decimal form as well * geosolutions-it#10663: fix adding decimals in the aeronautical form Description: - add helpful comment * geosolutions-it#10663: edit unit test in IntlNumberFormatControl-test.jsx to fix FE failure * geosolutions-it#10663: revert unnecessary change
Backport is done ---> #10678 |
tdipisa
pushed a commit
that referenced
this pull request
Nov 14, 2024
…rdinates (#10668) (#10678) * #10663: fix adding decimals in the aeronautical form Description: - handle fixing the issue of prevent enters centesimal number after the comma/dot in aeronautical form and decimal form as well * #10663: fix adding decimals in the aeronautical form Description: - add helpful comment * #10663: edit unit test in IntlNumberFormatControl-test.jsx to fix FE failure * #10663: revert unnecessary change
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles fixing the issue of prevent enters centesimal number after the comma/dot for
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10663
What is the current behavior?
#10663
What is the new behavior?
Now user can enter any centesimal numbers after the comma/dot like 0.04 , 15.1236 ...etc
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information