#10663: edit unit test in IntlNumberFormatControl-test.jsx to fix FE …

…failure
geosolutions-it · Nov 12, 2024 · 462b679 · 462b679
1 parent 58e7e6c
commit 462b679
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/web/client/components/I18N/__tests__/IntlNumberFormatControl-test.jsx b/web/client/components/I18N/__tests__/IntlNumberFormatControl-test.jsx
@@ -120,17 +120,17 @@ describe('IntlNumberFormControl', () => {
         TestUtils.Simulate.change(element, {target: {value: '12.'}});
         expect(element.value).toBe("12");
         TestUtils.Simulate.change(element, {target: {value: '12.0'}});
-        expect(element.value).toBe("12");
+        expect(element.value).toBe("12.0");
         TestUtils.Simulate.change(element, {target: {value: '12.04'}});
         expect(element.value).toBe("12.04");
         TestUtils.Simulate.change(element, {target: {value: '12.402'}});
         expect(element.value).toBe("12.402");
         TestUtils.Simulate.change(element, {target: {value: '-12.04'}});
         expect(element.value).toBe("-12.04");
         TestUtils.Simulate.change(element, {target: {value: '-12.40'}});
-        expect(element.value).toBe("-12.4");
+        expect(element.value).toBe("-12.40");
         TestUtils.Simulate.change(element, {target: {value: '-12.0'}});
-        expect(element.value).toBe("-12");
+        expect(element.value).toBe("-12.0");
     });
     it('check calling passed onkeydown, onkeyup events', () => {
         const intl = {locale: "en-US"};

diff --git a/web/client/libs/numeric-input/NumericInput.jsx b/web/client/libs/numeric-input/NumericInput.jsx
@@ -414,10 +414,10 @@ class NumericInput extends Component {
         const escapedDecimalSymbol = decimalSymbol.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
         const RE_TRAILING_DECIMAL_ZEROS = new RegExp(`\\d+${escapedDecimalSymbol}\\d*0+`);
 
-        // incomplete number
-        if (loose && RE_INCOMPLETE_NUMBER.test(stringValue)) {
+        // incomplete number or number contains decimal symbol [centesimal decimal numbers]
+        if ((loose && RE_INCOMPLETE_NUMBER.test(stringValue)) || RE_TRAILING_DECIMAL_ZEROS.test(stringValue)) {
             attrs.input.value = stringValue;
-        } else if ((loose && stringValue && !RE_NUMBER.test(stringValue)) || RE_TRAILING_DECIMAL_ZEROS.test(stringValue)) {// Not a number and not empty (loose mode only) || if number contains decimal symbol [centesimal decimal numbers]
+        } else if ((loose && stringValue && !RE_NUMBER.test(stringValue))) {// Not a number and not empty (loose mode only)
             attrs.input.value = stringValue;
         } else if (state.value || state.value === 0) { // number
             attrs.input.value = this._format(state.value);