ISSUE-198 - Reorganization of the plot of land interface, in particular for waste garbage cans

[LPoin]

Multiple changes to the parcel search interface:

• the ‘+’ button is now placed after the tabs used to search for plots, like a web browser.
• tab deletion is now done by a cross on each tab. The dustbin has been removed.
• the ‘search’ and ‘delete’ buttons have been grouped together in the plot search block to avoid confusion with the plot selection block below.

These changes have been reflected in the search for owners and co-owners to maintain the overall consistency of cadastrapp.

Tested in integration.
Mapstore 2023.02
Node 16.20.2

[landryb]

deployed locally, renders like this:

strangely i cant select plots anymore in the search results. i can doubleclick on the plot line and it opens the info form, i can tick the 'select all' box, but the box on the plot line is inactive. thus i cant select the plot line to test the trash...

creating a new empty selection tab 2, coming back to the selection 1 tab and clicking on the cross to close selection tab 2 destroys the wrong selection tab (ie tab1, the one where i had a plot from a map selection)

[LPoin]

Both issues have been fixed.

[landryb]

It's better, but there's still an UX annoyance: if you close a tab which isnt displayed/selected, after confirming, you get a blank area, and you need to reselect the previously selected tab, while it shouldn't stop showing the currently selected tab..

[pierrejego]

It's better, but there's still an UX annoyance: if you close a tab which isnt displayed/selected, after confirming, you get a blank area, and you need to reselect the previously selected tab, while it shouldn't stop showing the currently selected tab..

This is a regression, it was working on previous version. This point has to be corrected before merging

[Gaetanbrl]

You can also (other solution) just pass the delete func as property to reduce function complexity:

<DeletePlot delete={() => onTabDelete(index + (MAX_TABS - 1))}/>

Function :

function DeletePlot ({
    delete = () => {},
}) {    
    return (
        <OverlayTrigger placement="bottom" overlay={<Tooltip><Message msgId={'cadastrapp.search.deleteTab'}/></Tooltip>}>
            <ConfirmButton
                href="javascript:void(0)"
                confirmContent={<Message msgId={'cadastrapp.search.confirmDeleteTab'}/>}
                onClick={(e) => {
                    e.stopPropagation();
                    delete();
                    }}>
                <Glyphicon glyph="remove" />
            </ConfirmButton>
        </OverlayTrigger>
    )
}

[Gaetanbrl]

Minor not required change

[pierrejego]

Dans les tests effectués sur mapstore 2023-02-xx ( chrome et firefox ) , pour l'onglet "Compte propriétaire" les boutons "effacer" et "rechecher" sont cachés et donc pas accessible.

Sur les onglets "Nom d'usage ou de naissance" et Par lot les boutons rechercher ne fonctionne pas, refonctionne quand on recharge la page

[pierrejego]

Correction ok pour le bouton rechercher et l'adapation à la hauteur pour la recherche,

Par contre ça serait bien si le tableau de résultat s'adaptait aussi à la taille restante, pour ne mettre une scroll bar dans le tableau que si vraiment nécessaire et maximiser l'affichage des données avec l'espace disponible

[pierrejego]

See if 35 can be changed by a dynamic line height
Add comments to explain 30 and 200 px values ( 200 replace old 230 existing fixed values ) 30 margin to see object number

[pierrejego]

Ok Tested on Mapstore 2024-02.X and 2023-02-X

[landryb]

the .cadastrapp plotPanel class with the 10px padding added to the .geOrchestra .nav > li > a class is too much waste of space...

for consistency, it should align with the height/width of those tabs i think..

the fact that there's no scrollbar in the results table anymore is interesting,but it just shifts the scrollbar to the extension pane which feels weird too.. i suppose UX-wise, it should trigger some kind of pagination ?

[pierrejego]

We will have a look at the tab height

For the scrollbar, there are lots of differents case in the panel. We did not wanted to have two scrollbar when search panel is too long like this one.

This point need to be study, to find the best UI. For me an other issue need to be done

[landryb]

For the scrollbar, there are lots of differents case in the panel. We did not wanted to have two scrollbar when search panel is too long like this one.

right, hadn't thought about that case.. i guess.. it makes sense then.