Datadir automatic sync #126
Conversation
| @@ -393,6 +406,11 @@ rabbitmq: | |||
| # storage_class_name: default | |||
| # size: 1Gi | |||
|
|
|||
| gitCredentials: | |||
There was a problem hiding this comment.
Can't we reuse the values from here: https://github.com/georchestra/helm-georchestra/pull/126/files#diff-8377b3e3740a3fcd9f682e5fb55425f2fdbece1791854b9e5013e7f1a5e60e7eL213-L215?
| metadata: | ||
| namespace: {{ .Release.Namespace }} | ||
| name: {{ include "georchestra.fullname" . }}-datadirsync-role | ||
| rules: |
There was a problem hiding this comment.
Would it be possible to limit the roles to the deployments listed in deploymentSuffixNameList?
According to stackoverflow you can limit the access to certain deployments using resourceNames: https://stackoverflow.com/a/68980720
| rules: | ||
| - apiGroups: ["apps"] | ||
| resources: ["pods", "deployments"] | ||
| verbs: ["get", "list", "patch", "update"] |
There was a problem hiding this comment.
Why can't we limit ourselves to just: verbs: ["get", "patch"]?
https://stackoverflow.com/a/68980720
| - geoserver | ||
| - mapstore | ||
| - header | ||
| gitCredentials: |
There was a problem hiding this comment.
Could you explain what's the diff here with the other gitCredentials section in the YAML?
| @@ -263,6 +263,19 @@ georchestra: | |||
| # relay_username: aaaa | |||
| # relay_password: aaaa | |||
| extra_environment: [] | |||
| datadirsync: | |||
| enabled: true | |||
There was a problem hiding this comment.
Please put the datadir sync disabled by default.
| enabled: true | ||
| image: jemacchi/simple-git-rollout-operator:1.3.1 # TODO: image should be in context of c2c dockerhub account (?) | ||
| pollInterval: 10 | ||
| deploymentSuffixNameList: |
There was a problem hiding this comment.
One component is sufficient for the example. You can just limit to - geoserver
|
Hello jose, thank you for your contribution. I have reviewed your PR. Could you also please put a description to your PR so that other contributors understand what is it? You can also reference that it will close #75 |
No description provided.