Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemention of new WebComponent header #32

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

f-necas
Copy link

@f-necas f-necas commented Nov 11, 2023

georchestra/georchestra#4065

Implements the new georchestra/header in geoserver.
Main PR : georchestra/georchestra#4065

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@f-necas f-necas changed the title feat: implement new header Implemention of new WebComponent header Nov 22, 2023
Copy link

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @f-necas ! I'm not a Java expert for the code, but I can attest that it works.

import org.geoserver.web.GeoServerApplication;
import org.geotools.util.logging.Logging;

public class GeorchestraHeaderIframe extends InlineFrame {
public class GeorchestraHeaderIframe extends WebComponent {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably make sense to rename GeorchestraHeaderIframe?

@f-necas f-necas merged commit 3977e7f into 2.22.2-georchestra Nov 27, 2023
3 of 6 checks passed
@f-necas f-necas deleted the geor-header branch November 27, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants