Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race condition, resize map once target size ok #270

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Avoid race condition, resize map once target size ok #270

merged 1 commit into from
Dec 8, 2023

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Dec 8, 2023

Avoid map displaying wrong bbox.

Original commit : geoadmin/geocat@1d89c43

To implement upstream

@f-necas f-necas added this to the 23.0.5 milestone Dec 8, 2023
fgravin
fgravin approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for geocat and fixed the issue.
Tests are convincing.
+1

Thanks @f-necas

@fgravin fgravin merged commit 38c57c0 into georchestra-gn4.2.x Dec 8, 2023
1 check passed
@fgravin fgravin deleted the resize-map-after-target branch December 8, 2023 14:22
f-necas added a commit that referenced this pull request Dec 20, 2023
@f-necas
backport: avoid race condition, resize map once target size ok (#270)
c947c67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgravin fgravin fgravin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
23.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@f-necas @fgravin