-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub: Allow to set a feature limit for WFS #1085
Conversation
Affected libs:
|
📷 Screenshots are here! |
f0d8182
to
07f3745
Compare
ddbd47b
to
cbb883b
Compare
to set renamed exceedsWfsFeatureCountLimit$
…unt could not be defined for wfs version < 2.0
and use it in record-metadata
if exceedsWfsFeatureCountLimit$ is true
…eedsMaxFeatureCount$
…d move code there from record-metadata
…limit of features is exceeded instead of paginate
cbb883b
to
cf7697b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/datahub/src/app/record/record-data-preview/record-data-preview.component.ts
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/record/record-data-preview/record-data-preview.component.spec.ts
Outdated
Show resolved
Hide resolved
and do not try to load it if excludeWfs is true
Thanks for the review @jahow! You're right, that's what we said in the ticket. I've adapted the code accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works well! Please take a look at my comments, there seems to be an issue with the i18n:extract
task... we can fix that in another PR but you should at least make sure we're not losing any translation when mrging this PR. Thank you!
apps/datahub/src/app/record/record-data-preview/record-data-preview.component.ts
Show resolved
Hide resolved
0231621
to
c8bb819
Compare
Description
This PR introduces a new
max_feature_count
configuration. This allows to set a limit of WFS features to be displayed on the map, table and chart preview. If a number is set here and a WFS resource exceeds it, theThe goal of the PR is to improve performance and display consistent results on big datasets, where the backend might only respond with a limited number of features.
To-dos for this PR:
To-do for a separate PR:
Architectural changes
The PR has refactored the
record-metadata.component
and extracted relevant code for the preview section into arecord-data-preview.component
.Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label