Migration to Angular 18 #1070
Merged
Migration to Angular 18 #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
jahow
force-pushed
the
migrate-ng-19
branch
2 times, most recently
from
5a1d72f to
fecc6b7
Compare
|
📷 Screenshots are here! |
jahow
force-pushed
the
migrate-ng-19
branch
3 times, most recently
from
45749cb to
3ccd41d
Compare
jahow
force-pushed
the
migrate-ng-19
branch
5 times, most recently
from
95760c0 to
5ddca3f
Compare
jahow
added
the
breaking change
|
This is ready for review! I marked the PR as breaking change since the NPM package now requires Angular 18+ as well as a new peer dependency: The SSR part of the project has been disabled for now and will have to be restored properly in a different way. |
jahow
force-pushed
the
migrate-ng-19
branch
4 times, most recently
from
5e62cc7 to
e14114b
Compare
tkohr
approved these changes
Jan 20, 2025
| @@ -111,10 +111,10 @@ <h2>Next Steps</h2> | |||
| <summary>Add UI library</summary> | |||
| <pre> | |||
| # Generate UI lib | |||
| nx g @nx/angular:lib ui | |||
| nx g @nx/angular:lib ui | |||
There was a problem hiding this comment.
This is on purpose, I guess?
There was a problem hiding this comment.
yes, the @ was causing compilation issues :) see c831ae8
7 tasks
Also fix warnings
Also fix JSON type assertion in script
This was missing so storybook entries were not using the path shortcuts
* wait for results to show up before logging out otherwise we might end up with duplicated session cookies => not good * wait a bit before duplicating a record to be sure to pick the right one
This was making runs fail on the CI
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration to Angular 18 and Nx 20. Most of the work was:
Note: migration to Angular 19 was attempted and then left out because ng-mocks is not compatible with it yet.
To do:
Architectural changes
Screenshots
no visual changes
Quality Assurance Checklist
breaking changelabelbackport <release branch>labelThis work is sponsored by IGN.