Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map / Openlayers update #7421

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Map / Openlayers update #7421

wants to merge 1 commit into from

Conversation

fxprunayre
Copy link
Member

Changes :

  • Stamen layer now use StadiaMaps (need to add an API key for that?)
  • loadTile/loadImage function does not work as before
  • annotations panel do not display
  • ?

Following discussion in
#7387 (comment)

@fxprunayre
Map / Openlayers update
da222b4 
Changes required:
* Stamen layer
* loadTile/loadImage function
* annotations
* ...
@fxprunayre fxprunayre mentioned this pull request Oct 9, 2023
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jahow
Copy link
Contributor

jahow commented Oct 9, 2023 •
edited
Loading

A better approach would be to read the breaking changes from versions 7 and 8:

https://github.com/openlayers/openlayers/blob/v8.0.0/changelog/upgrade-notes.md#700

https://github.com/openlayers/openlayers/blob/v8.0.0/changelog/upgrade-notes.md#800

@josegar74
Copy link
Member

@fxprunayre can you update the commit message to indicate explicitly the version to upgrade?

From previous upgrades it's not that simple to check the version upgraded.

@jahow jahow mentioned this pull request Nov 14, 2023
Closed
@josegar74 josegar74 mentioned this pull request Feb 8, 2024
Merged
10 tasks
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fxprunayre @jahow @josegar74 @CLAassistant