Map / External map viewer should not redirect to map app #6548
Conversation
When an external mapviewer is configured, location URL is changed. Only change location if buildAddToMapConfig return a config. If not, then it has redirected to the external viewer.
|
Kudos, SonarCloud Quality Gate passed!
|
| $location.path('map').search({ | ||
| add: encodeURIComponent(angular.toJson( | ||
| [config]))}); | ||
| } | ||
| return; | ||
| }, | ||
| addAllMdLayersToMap: function (layers, md) { |
There was a problem hiding this comment.
buildAddToMapConfig is also used in this function and the logic doesn't seem it will work fine when using an external viewer.
Not a problem of this pull request, but the logic buildAddToMapConfig it's not very consistent in my opinion: returns a configuration value, when using the internal viewer, otherwise when using an external viewer executes an action, opening the viewer.
Also when adding several layers and using a external viewer, the logic in addAllMdLayersToMap would try to open the viewer multiple times, if it would work with the current logic, that I doubt it.
@fxprunayre, @jahow I was checking externalviewer.js to update the pull request code to work fine with the external viewer and noticed that this change seems intended to handle several chained view requests when calling the viewService method.
I'm not a Javascript expert, but checking the following code seems the purpose is to be able to call viewService several times and when finished open the viewer with all the metadata in _toView. But viewService calls every time the _commit method to open the viewer. So probably opens the viewer multiple times for each metadata?
As I said, probably I'm missing something, but can you explain how is this working to open the external viewer with multiple metadata?
There was a problem hiding this comment.
No the external viewer will be opened once and then the _toView array is emptied, so every subsequent call to _commit will have no effect.
There was a problem hiding this comment.
The _toView array contains all the layers that should be opened in the external viewer, that's it! every time viewService is called, a layer is added in _toView and on the first call to _commit the external viewer is opened with all the layers.
| add: encodeURIComponent(angular.toJson([buildAddToMapConfig(link, md)])) | ||
| }); | ||
| var config = buildAddToMapConfig(link, md); | ||
| if (angular.isObject(config)) { |
There was a problem hiding this comment.
Just a question: why use angular.isObject? config will be undefined right? why not just config === undefined??
|
not 100% sure, but is it the same issue as |
|
Could this PR be merged? |
|
Superseded by changes in #7387 |
When an external mapviewer is configured, location URL is changed. Only change location if buildAddToMapConfig return a config. If not, then it has redirected to the external viewer.