Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge column and use init.dt event #5

Merged
merged 3 commits into from
May 7, 2024
Merged

Fix merge column and use init.dt event #5

merged 3 commits into from
May 7, 2024

Conversation

jdugh
Copy link
Member

@jdugh jdugh commented May 7, 2024

If you have only standard column (mulitple headers config without any headerGroup), the merge doesn't work well.

Set the Filters construction in the 'init.dt' event for prevent the async operation (like when langage is an url)
Set the scrollYFitToScreen fonction also in 'init.dt' event for better calculation
Add the offsetHeight calculate for .top and .bottom (if you use dom configuration)

@jdugh jdugh self-assigned this May 7, 2024
@sgigh
Copy link
Member

sgigh commented May 7, 2024

Ok for your request

@sgigh sgigh closed this May 7, 2024
@sgigh sgigh reopened this May 7, 2024
@sgigh
Copy link
Member

sgigh commented May 7, 2024

ok for your request

@sgigh sgigh closed this May 7, 2024
@jdugh jdugh reopened this May 7, 2024
Copy link
Member

@sgigh sgigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is ok

Copy link
Member

@sgigh sgigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok

@sgigh sgigh merged commit eb86f12 into master May 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants