Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docker image for the TACC systems has been broken for a while: https://github.com/geodynamics/aspect/actions/workflows/docker.yml.
This PR fixes a few issues to fix the workflow:
I had to disable the ASPECT examples, because I couldnt get them to compile as part of the general build process. They would always try to use the non MPI compiler and fail with:
I am pretty sure this is somehow related to dealii/candi#207 but no matter how I set
USE_DEAL_II_CMAKE_MPI_COMPILER
the problem persists. Additionally, if I start the resulting docker image and manually compile the example plugins everything works fine, so it is only related to usingDASPECT_INSTALL_EXAMPLES=ON
in the full ASPECT build process. After a few hours of digging through the problem I gave up and decided to disable compiling the examples. I think this is fair, because the use case of this image is to run large-scale models on the TACC systems, not to make it easy to run our examples.